-
Notifications
You must be signed in to change notification settings - Fork 79
Added script to build the cli and wrap it as docker container 'snow-cli' #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sfc-gh-gjachimko
wants to merge
2
commits into
dcm-pipeline-commands
Choose a base branch
from
gjachimko-add-docker-build
base: dcm-pipeline-commands
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Git | ||
| .git | ||
| .gitignore | ||
| .github | ||
|
|
||
| # Python | ||
| __pycache__ | ||
| *.py[cod] | ||
| *$py.class | ||
| *.so | ||
| .Python | ||
| build/ | ||
| develop-eggs/ | ||
| dist/ | ||
| downloads/ | ||
| eggs/ | ||
| .eggs/ | ||
| lib/ | ||
| lib64/ | ||
| parts/ | ||
| sdist/ | ||
| var/ | ||
| wheels/ | ||
| *.egg-info/ | ||
| .installed.cfg | ||
| *.egg | ||
| venv/ | ||
| env/ | ||
| ENV/ | ||
|
|
||
| # Testing | ||
| .pytest_cache/ | ||
| .coverage | ||
| htmlcov/ | ||
| tests/ | ||
| tests_*/ | ||
| test_external_plugins/ | ||
| conftest.py | ||
|
|
||
| # IDE | ||
| .vscode/ | ||
| .idea/ | ||
| *.swp | ||
| *.swo | ||
| *~ | ||
|
|
||
| # Documentation | ||
| docs/ | ||
| *.md | ||
| !README.md | ||
|
|
||
| # CI/CD | ||
| .pre-commit-config.yaml | ||
|
|
||
| # Other | ||
| *.log | ||
| .DS_Store | ||
| scripts/ | ||
| snyk/ | ||
| performance_history_analysis.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # step 1 - build the cli | ||
| FROM python:3.10-slim AS builder | ||
| WORKDIR /build | ||
| RUN apt-get update && apt-get install -y \ | ||
| gcc \ | ||
| g++ \ | ||
| libffi-dev \ | ||
| libssl-dev \ | ||
| git \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| COPY pyproject.toml ./ | ||
| COPY README.md ./ | ||
| COPY LICENSE ./ | ||
| COPY src ./src | ||
|
|
||
| RUN pip install --no-cache-dir hatch && hatch build -t wheel | ||
|
|
||
| # step 2 - package the cli to a minimal image | ||
| FROM python:3.10-slim | ||
| RUN apt-get update && apt-get install -y libssl3 && rm -rf /var/lib/apt/lists/* | ||
| WORKDIR /app | ||
| COPY --from=builder /build/dist/*.whl /tmp/ | ||
| RUN pip install --no-cache-dir /tmp/*.whl && rm -rf /tmp/*.whl | ||
| ENV SF_SKIP_WARNING_FOR_READ_PERMISSIONS_ON_CONFIG_FILE=true | ||
| ENTRYPOINT ["snow"] | ||
| CMD ["--help"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #!/bin/bash | ||
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" | ||
|
|
||
| echo "Building snowflake-cli Docker image..." | ||
| echo "=======================================" | ||
|
|
||
| docker build --progress=plain -t snowflake-cli "$SCRIPT_DIR" | ||
|
|
||
| if [ $? -eq 0 ]; then | ||
| echo "" | ||
| echo "=======================================" | ||
| echo "Build successful!" | ||
| echo "Image: snowflake-cli:latest" | ||
| echo "" | ||
| echo "Usage:" | ||
| echo " docker run --rm snowflake-cli --version" | ||
| echo " docker run --rm snowflake-cli --help" | ||
| else | ||
| echo "" | ||
| echo "=======================================" | ||
| echo "Build failed!" | ||
| exit 1 | ||
| fi | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage examples reference
snowflake-clias the image name, but the PR title mentions creating asnow-clicontainer. For consistency, either:Update these examples to use
snow-cli:Or ensure the Docker build process uses
snowflake-clias the image name throughout the implementation.Maintaining consistent naming will prevent confusion for users following these examples.
Spotted by Graphite Agent

Is this helpful? React 👍 or 👎 to let us know.