- 
                Notifications
    You must be signed in to change notification settings 
- Fork 524
SNOW-2333702 Fix types for DictCursor #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
 This stack of pull requests is managed by Graphite. Learn more about stacking. | 
325d395    to
    ec95863      
    Compare
  
    90c833a    to
    29b5b7e      
    Compare
  
    ec95863    to
    3e1805e      
    Compare
  
    3e1805e    to
    2d014a0      
    Compare
  
    2d014a0    to
    42ed777      
    Compare
  
    42ed777    to
    ac6f96b      
    Compare
  
    ac6f96b    to
    6394dbb      
    Compare
  
    6394dbb    to
    34d9d94      
    Compare
  
    34d9d94    to
    000d9bb      
    Compare
  
    
              
                    sfc-gh-pczajka
  
              
              approved these changes
              
                  
                    Sep 29, 2025 
                  
              
              
            
            
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Port PR: https://github.com/snowflakedb/Stored-Proc-Python-Connector/pull/225
On main, the following code shows the following mypy errors:
error: Incompatible types in assignment (expression has type "SnowflakeCursor", variable has type "DictCursor") [assignment]error: No overload variant of "__getitem__" of "tuple" matches argument type "str" [call-overload]This change fixes both errors.