Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sfc-gh-bchinn
force-pushed
the
bchinn-mypy-cursor
branch
from
e4027bd to
b75d7c7
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-SNOW-2333702-conn-cursor
branch
2 times, most recently
from
ac6f96b to
6394dbb
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-mypy-cursor
branch
from
b75d7c7 to
49178e9
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-SNOW-2333702-conn-cursor
branch
from
6394dbb to
34d9d94
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-mypy-cursor
branch
from
49178e9 to
1bbacad
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-SNOW-2333702-conn-cursor
branch
from
34d9d94 to
000d9bb
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-mypy-cursor
branch
2 times, most recently
from
8d2fa7b to
44895d0
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-mypy-cursor
branch
from
44895d0 to
74ae983
Compare
sfc-gh-bchinn
added
the
NO-CHANGELOG-UPDATES
Graphite App
sfc-gh-bchinn
force-pushed
the
bchinn-mypy-cursor
branch
from
74ae983 to
2b47004
Compare
sfc-gh-bchinn
force-pushed
the
bchinn-mypy-cursor
branch
from
2b47004 to
58f8c3b
Compare
Contributor
|
@sfc-gh-bchinn can we please wait with this change before we merge async io support from |
Contributor
Author
|
@sfc-gh-turbaszek Sure thing! I'll remove this from the port PR then |
Contributor
Author
|
@sfc-gh-turbaszek I broke out one of the commits into a separate PR, since we're holding off on this bigger change. Can you take a look at that? #2603 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run mypy on
cursor.pyand fix issues.All
assertsadded in this PR are safe; if the condition was violated, it would've been anAttributeErrorin a subsequent line anyway.