Skip to content

Fix daily precommit test when pandas not installed #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-yuwang merged 3 commits into from
Nov 26, 2024
Merged

Fix daily precommit test when pandas not installed #2676

sfc-gh-yuwang merged 3 commits into from
Nov 26, 2024

Conversation

@sfc-gh-yuwang
Copy link
Collaborator

@sfc-gh-yuwang sfc-gh-yuwang commented Nov 25, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    This test: https://github.com/snowflakedb/snowpark-python/actions/runs/12020244963/job/33508548503
    verified the fix is successful

@sfc-gh-yuwang sfc-gh-yuwang requested a review from a team as a code owner November 25, 2024 18:41
@sfc-gh-yuwang sfc-gh-yuwang added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Nov 25, 2024
@sfc-gh-yuwang sfc-gh-yuwang merged commit 03230b7 into main Nov 26, 2024
125 of 130 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the yuwang-fix-daily-precommit branch November 26, 2024 22:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@sfc-gh-yuwang sfc-gh-yuwang restored the yuwang-fix-daily-precommit branch February 13, 2025 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-yuwang @sfc-gh-jdu @sfc-gh-aling