Skip to content

Fix daily precommit test when pandas not installed #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-yuwang merged 3 commits into from
Nov 26, 2024
Merged

Fix daily precommit test when pandas not installed #2676

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43125e1
fix test
sfc-gh-yuwang Nov 25, 2024
41b09f6
fix test
sfc-gh-yuwang Nov 25, 2024
d219a32
fix test
sfc-gh-yuwang Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions tests/unit/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,7 +1237,9 @@ def test_snow_type_to_dtype_str():
{"name": "col2", "type": "float"},
],
},
),
)
if is_pandas_available
else (None, None, None, None, None),
(
PandasDataFrameType(
[ArrayType(ArrayType(IntegerType())), IntegerType(), FloatType()]
Expand All @@ -1262,24 +1264,32 @@ def test_snow_type_to_dtype_str():
{"name": "", "type": "float"},
],
},
),
)
if is_pandas_available
else (None, None, None, None, None),
(
PandasSeriesType(IntegerType()),
"pandas_series<int>",
'{"element_type":"integer","type":"pandas_series"}',
"pandas_series",
{"type": "pandas_series", "element_type": "integer"},
),
)
if is_pandas_available
else (None, None, None, None, None),
(
PandasSeriesType(None),
"pandas_series<>",
'{"element_type":null,"type":"pandas_series"}',
"pandas_series",
{"type": "pandas_series", "element_type": None},
),
)
if is_pandas_available
else (None, None, None, None, None),
],
)
def test_datatype(tpe, simple_string, json, type_name, json_value):
if tpe is None:
pytest.skip("skip because pandas is not available")
assert tpe.simple_string() == simple_string
assert tpe.json_value() == json_value
assert tpe.json() == json
Expand Down Expand Up @@ -1371,18 +1381,28 @@ def test_datatype(tpe, simple_string, json, type_name, json_value):
PandasDataFrameType(
[StringType(), IntegerType(), FloatType()], ["id", "col1", "col2"]
),
),
)
if is_pandas_available
else (None, None),
(
PandasDataFrameType,
PandasDataFrameType(
[ArrayType(ArrayType(IntegerType())), IntegerType(), FloatType()]
),
),
(PandasSeriesType, PandasSeriesType(IntegerType())),
(PandasSeriesType, PandasSeriesType(None)),
)
if is_pandas_available
else (None, None),
(PandasSeriesType, PandasSeriesType(IntegerType()))
if is_pandas_available
else (None, None),
(PandasSeriesType, PandasSeriesType(None))
if is_pandas_available
else (None, None),
],
)
def test_structtype_from_json(datatype, tpe):
if datatype is None:
pytest.skip("skip because pandas is not available")
json_dict = tpe.json_value()
new_obj = datatype.from_json(json_dict)
assert new_obj == tpe
Expand Down
Loading