Skip to content

NO-SNOW: Fix flaky sql commit test#2910

Merged
sfc-gh-jrose merged 6 commits intomainfrom
jrose_snow_no_snow_fix_flaky_sql_commit_test
Jan 24, 2025
Merged

NO-SNOW: Fix flaky sql commit test#2910
sfc-gh-jrose merged 6 commits intomainfrom
jrose_snow_no_snow_fix_flaky_sql_commit_test

Conversation

@sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes NO-SNOW

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    I suspect the reason this test is flaky is due to pytest-xdist parallelism. Other tests in this module may be interfering with the session so I've created a session specifically for this test.

Daily precommit running here to try to verify:
https://github.com/snowflakedb/snowpark-python/actions/runs/12916539477

@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 22, 2025
@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review January 24, 2025 03:18
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner January 24, 2025 03:18
@sfc-gh-jrose sfc-gh-jrose merged commit 7af90b1 into main Jan 24, 2025
38 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_no_snow_fix_flaky_sql_commit_test branch January 24, 2025 06:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants