Skip to content

NO-SNOW: Fix flaky sql commit test #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-jrose merged 6 commits into from
Jan 24, 2025
Merged

NO-SNOW: Fix flaky sql commit test #2910

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b2507c
NO-SNOW: Fix flaky sql commit test
sfc-gh-jrose Jan 22, 2025
f016f4a
Merge branch 'main' into jrose_snow_no_snow_fix_flaky_sql_commit_test
sfc-gh-jrose Jan 22, 2025
a6f5369
fixup
sfc-gh-jrose Jan 23, 2025
722d278
Merge branch 'main' into jrose_snow_no_snow_fix_flaky_sql_commit_test
sfc-gh-jrose Jan 23, 2025
0de7c91
Merge branch 'main' into jrose_snow_no_snow_fix_flaky_sql_commit_test
sfc-gh-jrose Jan 24, 2025
a012132
Merge branch 'main' into jrose_snow_no_snow_fix_flaky_sql_commit_test
sfc-gh-jrose Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tests/integ/scala/test_session_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@
from snowflake.connector.errors import DatabaseError
from snowflake.snowpark import Row, Session
from snowflake.snowpark._internal.utils import (
AstFlagSource,
TempObjectType,
get_application_name,
get_python_version,
get_version,
quote_name,
set_ast_state,
)
from snowflake.snowpark.exceptions import (
SnowparkInvalidObjectNameException,
Expand Down Expand Up @@ -277,7 +279,18 @@ def test_large_local_relation_no_commit(session):
reason="transactions not supported by local testing.",
run=False,
)
def test_create_temp_table_no_commit(session):
def test_create_temp_table_no_commit(
db_parameters,
sql_simplifier_enabled,
cte_optimization_enabled,
ast_enabled,
):
set_ast_state(AstFlagSource.TEST, ast_enabled)
session = Session.builder.configs(db_parameters).create()
session.sql_simplifier_enabled = sql_simplifier_enabled
session._cte_optimization_enabled = cte_optimization_enabled
session.ast_enabled = ast_enabled

# cache_result creates a temp table
test_table = Utils.random_name_for_temp_object(TempObjectType.TABLE)
try:
Expand All @@ -291,3 +304,4 @@ def test_create_temp_table_no_commit(session):
assert not Utils.is_active_transaction(session)
finally:
Utils.drop_table(session, test_table)
session.close()
Loading