Skip to content

Conversation

@sfc-gh-joshi
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi commented Apr 21, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2046103

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

Fixes a failure in the daily test that occurs when pandas is not installed due to an incorrect expected error message.

Also skips test_ast[df_copy.test] in Python 3.12 environments (slack discussion).

Relevant daily tests passing: https://github.com/snowflakedb/snowpark-python/actions/runs/14601741926/job/40961489775 (failures are either unrelated or transient).

@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Apr 21, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-joshi sfc-gh-joshi added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Apr 21, 2025
@sfc-gh-joshi sfc-gh-joshi force-pushed the joshi-SNOW-2046103-daily-failures branch from 37388fc to 49b982a Compare April 22, 2025 17:05
@sfc-gh-joshi sfc-gh-joshi requested a review from a team as a code owner April 22, 2025 18:12
@sfc-gh-joshi sfc-gh-joshi changed the title SNOW-2046103: Fix no pandas daily test failure SNOW-2046103: Fix no pandas and AST daily test failures Apr 22, 2025
@sfc-gh-joshi sfc-gh-joshi merged commit e699e8c into main Apr 22, 2025
127 of 134 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi-SNOW-2046103-daily-failures branch April 22, 2025 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants