Skip to content

SNOW-2046103: Fix no pandas and AST daily test failures #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-joshi merged 2 commits into from
Apr 22, 2025
Merged

SNOW-2046103: Fix no pandas and AST daily test failures #3289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49b982a
fix no pandas test
sfc-gh-joshi Apr 21, 2025
27abb20
skip ast[df_copy] on python 3.12
sfc-gh-joshi Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/ast/test_ast_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,15 @@ def load_test_cases():
Returns: a list of test cases.
"""
test_files = DATA_DIR.glob("*.test")
if sys.version_info[0] == 3 and sys.version_info[1] < 9:
major_version, minor_version = sys.version_info[0], sys.version_info[1]
if major_version == 3 and minor_version < 9:
# Remove the `to_snowpark_pandas` test since Snowpark pandas is only supported in Python 3.9+.
test_files = filter(
lambda file: "to_snowpark_pandas" not in file.name, test_files
)
if major_version == 3 and minor_version == 12:
# Skip df_copy when run in Python 3.12 due to differences in reported source positions.
test_files = filter(lambda file: "df_copy" not in file.name, test_files)
return [parse_file(file) for file in test_files]


Expand Down
7 changes: 7 additions & 0 deletions tests/integ/test_df_to_snowpark_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ def tmp_table_basic(session):
@pytest.mark.parametrize("enforce_ordering", [True, False])
def test_to_snowpark_pandas_no_modin(session, tmp_table_basic, enforce_ordering):
snowpark_df = session.table(tmp_table_basic)
# If pandas isn't installed, then an error is raised immediately.
try:
import pandas # noqa: F401
except ModuleNotFoundError:
with pytest.raises(ModuleNotFoundError, match="No module named 'pandas'"):
snowpark_df.to_snowpark_pandas(enforce_ordering=enforce_ordering)
return
# Check if modin is installed (if so, we're running in Snowpark pandas; if not, we're just in Snowpark Python)
try:
import modin # noqa: F401
Expand Down
Loading