Skip to content

SNOW-2086682: Add telemetry for XML reader with row tag #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-jdu merged 2 commits into from
May 13, 2025
Merged

SNOW-2086682: Add telemetry for XML reader with row tag #3355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e044b
d
sfc-gh-jdu May 12, 2025
f168b40
fix
sfc-gh-jdu May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/snowflake/snowpark/_internal/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@
XML_ROW_TAG_STRING = "ROWTAG"
XML_ROW_DATA_COLUMN_NAME = "ROW_DATA"
XML_READER_FILE_PATH = os.path.join(os.path.dirname(__file__), "xml_reader.py")
XML_READER_SQL_COMMENT = "/* Python:snowflake.snowpark.DataFrameReader.xml[rowTag] */"

QUERY_TAG_STRING = "QUERY_TAG"
SKIP_LEVELS_TWO = (
Expand Down
6 changes: 5 additions & 1 deletion src/snowflake/snowpark/dataframe_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
XML_ROW_TAG_STRING,
XML_ROW_DATA_COLUMN_NAME,
XML_READER_FILE_PATH,
XML_READER_SQL_COMMENT,
INFER_SCHEMA_FORMAT_TYPES,
SNOWFLAKE_PATH_PREFIXES,
TempObjectType,
Expand Down Expand Up @@ -1159,7 +1160,10 @@ def _read_semi_structured_file(self, path: str, format: str) -> DataFrame:
_emit_ast=False,
)
df._reader = self
set_api_call_source(df, f"DataFrameReader.{format.lower()}")
if xml_reader_udtf:
set_api_call_source(df, XML_READER_SQL_COMMENT)
Copy link
Copy Markdown
Contributor

@sfc-gh-jrose sfc-gh-jrose May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be DataFrameReader.xml[rowTag] instead of the entire comment.

Copy link
Copy Markdown
Collaborator Author

@sfc-gh-jdu sfc-gh-jdu May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

else:
set_api_call_source(df, f"DataFrameReader.{format.lower()}")
return df

@private_preview(version="1.29.0")
Expand Down
Loading