Skip to content

SNOW-2086682: Add telemetry for XML reader with row tag#3355

Merged
sfc-gh-jdu merged 2 commits intomainfrom
jdu-2086682-add-telemetry-xml
May 13, 2025
Merged

SNOW-2086682: Add telemetry for XML reader with row tag#3355
sfc-gh-jdu merged 2 commits intomainfrom
jdu-2086682-add-telemetry-xml

Conversation

@sfc-gh-jdu
Copy link
Copy Markdown
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2086682

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-jdu sfc-gh-jdu requested review from a team as code owners May 12, 2025 22:00
@sfc-gh-jdu sfc-gh-jdu added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 12, 2025
@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown

sfc-gh-snowflakedb-snyk-sa commented May 12, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

df._reader = self
set_api_call_source(df, f"DataFrameReader.{format.lower()}")
if xml_reader_udtf:
set_api_call_source(df, XML_READER_SQL_COMMENT)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be DataFrameReader.xml[rowTag] instead of the entire comment.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

@sfc-gh-jdu sfc-gh-jdu merged commit 9cfefe0 into main May 13, 2025
40 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-2086682-add-telemetry-xml branch May 13, 2025 20:47
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants