SNOW-2086682: Add telemetry for XML reader with row tag#3355
Merged
sfc-gh-jdu merged 2 commits intomainfrom May 13, 2025
Merged
SNOW-2086682: Add telemetry for XML reader with row tag#3355sfc-gh-jdu merged 2 commits intomainfrom
sfc-gh-jdu merged 2 commits intomainfrom
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
| df._reader = self | ||
| set_api_call_source(df, f"DataFrameReader.{format.lower()}") | ||
| if xml_reader_udtf: | ||
| set_api_call_source(df, XML_READER_SQL_COMMENT) |
Contributor
There was a problem hiding this comment.
I think this should be DataFrameReader.xml[rowTag] instead of the entire comment.
Collaborator
Author
There was a problem hiding this comment.
good catch, fixed
sfc-gh-jrose
approved these changes
May 13, 2025
sfc-gh-aalam
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2086682
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.