drivers: display: send DISPON after ili9xxx sleep exit #21
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| * command is issued. Applications are still free to call | ||
| * display_blanking_off(), as sending DISPON twice is harmless. | ||
| */ | ||
| r = ili9xxx_display_blanking_off(dev); |
There was a problem hiding this comment.
[P0] Declare ili9xxx_display_blanking_off before calling it
The added call to ili9xxx_display_blanking_off(dev) occurs before the function is declared or defined in this translation unit. In C99 builds (Zephyr treats implicit declarations as errors), this results in implicit declaration of function 'ili9xxx_display_blanking_off' and the ili9xxx driver fails to compile whenever it is included. Introduce a forward declaration or move the definition above this call so the driver still builds.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d94706d3c083228104b889b7f0d5f8