Skip to content

drivers: display: send DISPON after ili9xxx sleep exit #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: display_3wire
Choose a base branch
from
Open

drivers: display: send DISPON after ili9xxx sleep exit #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions drivers/display/display_ili9xxx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,27 @@

static int ili9xxx_exit_sleep(const struct device *dev)
{
int r;

r = ili9xxx_transmit(dev, ILI9XXX_SLPOUT, NULL, 0);
if (r < 0) {
return r;
}

k_sleep(K_MSEC(ILI9XXX_SLEEP_OUT_TIME));

return 0;
int r;

Check warning on line 78 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:78  please, no spaces at the start of a line

Check failure on line 78 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:78  code indent should use tabs where possible

r = ili9xxx_transmit(dev, ILI9XXX_SLPOUT, NULL, 0);

Check warning on line 80 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:80  please, no spaces at the start of a line

Check failure on line 80 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:80  code indent should use tabs where possible
if (r < 0) {

Check warning on line 81 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:81  please, no spaces at the start of a line

Check failure on line 81 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:81  code indent should use tabs where possible
return r;

Check warning on line 82 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:82  please, no spaces at the start of a line

Check failure on line 82 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:82  code indent should use tabs where possible
}

Check warning on line 83 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:83  please, no spaces at the start of a line

Check failure on line 83 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:83  code indent should use tabs where possible

k_sleep(K_MSEC(ILI9XXX_SLEEP_OUT_TIME));

Check warning on line 85 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:85  please, no spaces at the start of a line

Check failure on line 85 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:85  code indent should use tabs where possible

/*

Check failure on line 87 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:87  code indent should use tabs where possible
* Some panels, including the one fitted to the M5Stack Core2,

Check failure on line 88 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:88  code indent should use tabs where possible
* keep the display output blank after SLPOUT until a DISPON

Check failure on line 89 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:89  code indent should use tabs where possible
* command is issued. Applications are still free to call

Check failure on line 90 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

drivers/display/display_ili9xxx.c:90  code indent should use tabs where possible
* display_blanking_off(), as sending DISPON twice is harmless.
*/
r = ili9xxx_display_blanking_off(dev);

Check warning on line 93 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:93  please, no spaces at the start of a line
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] Declare ili9xxx_display_blanking_off before calling it

The added call to ili9xxx_display_blanking_off(dev) occurs before the function is declared or defined in this translation unit. In C99 builds (Zephyr treats implicit declarations as errors), this results in implicit declaration of function 'ili9xxx_display_blanking_off' and the ili9xxx driver fails to compile whenever it is included. Introduce a forward declaration or move the definition above this call so the driver still builds.

Useful? React with 👍 / 👎.

if (r < 0) {

Check warning on line 94 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:94  please, no spaces at the start of a line
return r;

Check warning on line 95 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:95  please, no spaces at the start of a line
}

Check warning on line 96 in drivers/display/display_ili9xxx.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

drivers/display/display_ili9xxx.c:96  please, no spaces at the start of a line

return 0;
}

static void ili9xxx_hw_reset(const struct device *dev)
Expand Down
Loading