Skip to content

Conversation

@hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Mar 6, 2025

Apply the lifecycle cleaning , looking for SOFA_ATTRIBUTE_DISABLED.*\n.*".*".*"v24.06" (and older versions)

[ci-depends-on https://github.com/sofa-framework/Regression/pull/76]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Mar 6, 2025
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request and removed pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress labels Mar 6, 2025
@hugtalbot hugtalbot force-pushed the 202503_remove_SOFA_ATTRIBUTE_DISABLED branch 2 times, most recently from 8f7dd7e to c6368bc Compare March 7, 2025 15:19
@hugtalbot
Copy link
Contributor Author

It seems that the last commit of this PR ( c6368bc ) breaks a lot of things (unit, scene and regression tests!)

This piece of code comes from #4350 from @fredroy
This relates to the errors in #5245

Any 👀 are welcome!

@fredroy fredroy force-pushed the 202503_remove_SOFA_ATTRIBUTE_DISABLED branch from c6368bc to 184eb01 Compare March 12, 2025 22:47
@fredroy fredroy force-pushed the 202503_remove_SOFA_ATTRIBUTE_DISABLED branch from 184eb01 to 5563d63 Compare March 13, 2025 02:32
@sofabot
Copy link
Collaborator

sofabot commented Mar 13, 2025

[ci-depends-on] detected during build #12.

To unlock the merge button, you must

@fredroy fredroy force-pushed the 202503_remove_SOFA_ATTRIBUTE_DISABLED branch from 7c32d56 to 9929a2f Compare March 14, 2025 00:27
@sofabot
Copy link
Collaborator

sofabot commented Mar 14, 2025

[ci-depends-on] detected during build #13.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@fredroy fredroy merged commit 196856f into sofa-framework:master Mar 14, 2025
11 checks passed
@hugtalbot hugtalbot changed the title [all] Remove SOFA_ATTRIBUTE_DISABLED [all] Lifecycle : remove SOFA_ATTRIBUTE_DISABLED Mar 14, 2025
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 16, 2025
@hugtalbot hugtalbot added this to the v25.06 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants