Change OSSRH to Central Portal#1382
Conversation
Signed-off-by: JermaineHua <crazyhzm@apache.org>
Signed-off-by: JermaineHua <crazyhzm@apache.org>
WalkthroughThe Maven build configuration was updated to migrate from the deprecated Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Maven
participant CentralPublishingPlugin
participant SonatypeCentral
Developer->>Maven: mvn deploy (with release profile)
Maven->>CentralPublishingPlugin: Invoke publish
CentralPublishingPlugin->>SonatypeCentral: Upload artifacts
SonatypeCentral-->>CentralPublishingPlugin: Acknowledge receipt
CentralPublishingPlugin-->>Maven: Report publish status
Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
# Conflicts: # pom.xml
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pom.xml (1)
46-48: Consider dropping the now-unusedmaven.staging.pluginpropertyWith the migration away from
nexus-staging-maven-plugin, this property no longer drives anything in the current POM. Keeping dead properties increases maintenance overhead and can confuse future readers.- <maven.staging.plugin>1.7.0</maven.staging.plugin>sofa-boot-tests/pom.xml (1)
70-76:<extensions>true</extensions>probably unnecessary hereBecause this child module merely disables publishing via
<skipPublishing>true</skipPublishing>, the build doesn’t rely on the plugin as a core build extension. Removing the flag will shorten Maven’s class-path and speed up reactor startup a little.- <extensions>true</extensions>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pom.xml(3 hunks)sofa-boot-tests/pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: sca
🔇 Additional comments (3)
pom.xml (2)
94-101: Double-check Central Publishing plugin coordinates & params
- Group Id
org.sonatype.centraland version0.8.0look plausible, but the official artefact is currently published underio.github.sonatype.central(verify against Maven Central).- The plugin’s XML param was recently renamed from
publishingServerId→serverId. Using the older key may cause “unknown parameter” failures.Recommend confirming against the plugin’s latest README before releasing.
134-144: Validate new snapshot repository URL
https://central.sonatype.com/repository/maven-snapshots/is still in beta and may intermittently redirect. Ensure:
- Credentials on
${settings.xml}match<id>snapshot</id>- CI/CD firewalls allow the new host
A quick
mvn -U deploy -DskipTestsdry-run from CI will surface any connectivity issues early.sofa-boot-tests/pom.xml (1)
70-76: Ensure parent definescentral-publishing-maven-plugin.versionThe version is inherited from the root POM. If anyone builds this module in isolation (e.g., via
mvn -pl sofa-boot-tests -am install), the property must still resolve. Confirm the root POM is always included in such commands, or duplicate the property locally.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1382 +/- ##
============================================
- Coverage 82.96% 82.91% -0.06%
+ Complexity 2973 2972 -1
============================================
Files 340 340
Lines 9833 9833
Branches 1178 1178
============================================
- Hits 8158 8153 -5
- Misses 1160 1164 +4
- Partials 515 516 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit