Skip to content

Change OSSRH to Central Portal#1382

Merged
CrazyHZM merged 3 commits intosofastack:masterfrom
CrazyHZM:4.x_feat/nexus-staging-maven-plugin
Jul 2, 2025
Merged

Change OSSRH to Central Portal#1382
CrazyHZM merged 3 commits intosofastack:masterfrom
CrazyHZM:4.x_feat/nexus-staging-maven-plugin

Conversation

@CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Jul 2, 2025

Summary by CodeRabbit

  • Chores
    • Updated Maven configuration to use the new central publishing plugin and updated repository URLs.
    • Removed outdated repository and distribution management settings.
    • Simplified plugin configuration for publishing and staging.

CrazyHZM added 2 commits July 1, 2025 13:14
Signed-off-by: JermaineHua <crazyhzm@apache.org>
Signed-off-by: JermaineHua <crazyhzm@apache.org>
@coderabbitai
Copy link

coderabbitai bot commented Jul 2, 2025

Walkthrough

The Maven build configuration was updated to migrate from the deprecated nexus-staging-maven-plugin to the new central-publishing-maven-plugin for publishing releases. This involved updating plugin declarations, configuration keys, repository URLs, and removing obsolete distribution management sections in both the main and test module POM files.

Changes

File(s) Change Summary
pom.xml Migrated to central-publishing-maven-plugin, updated plugin versions, configuration keys, repository URLs, and removed distributionManagement.
sofa-boot-tests/pom.xml Replaced staging plugin with central publishing plugin, updated skip configuration, added extensions flag.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Maven
    participant CentralPublishingPlugin
    participant SonatypeCentral

    Developer->>Maven: mvn deploy (with release profile)
    Maven->>CentralPublishingPlugin: Invoke publish
    CentralPublishingPlugin->>SonatypeCentral: Upload artifacts
    SonatypeCentral-->>CentralPublishingPlugin: Acknowledge receipt
    CentralPublishingPlugin-->>Maven: Report publish status
Loading

Possibly related PRs

Suggested labels

size/XS

Poem

A hop and a skip, the plugins renew,
Maven’s old ways bid a fond adieu.
With central publishing, the path is clear,
Artifacts leap to Sonatype’s sphere.
So here’s a cheer, with paws held high—
For smoother releases, let’s multiply!
((\
( -.-)
o_(")(")


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CrazyHZM CrazyHZM merged commit 88bf7da into sofastack:master Jul 2, 2025
4 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
pom.xml (1)

46-48: Consider dropping the now-unused maven.staging.plugin property

With the migration away from nexus-staging-maven-plugin, this property no longer drives anything in the current POM. Keeping dead properties increases maintenance overhead and can confuse future readers.

-        <maven.staging.plugin>1.7.0</maven.staging.plugin>
sofa-boot-tests/pom.xml (1)

70-76: <extensions>true</extensions> probably unnecessary here

Because this child module merely disables publishing via <skipPublishing>true</skipPublishing>, the build doesn’t rely on the plugin as a core build extension. Removing the flag will shorten Maven’s class-path and speed up reactor startup a little.

-                <extensions>true</extensions>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b316495 and ca65177.

📒 Files selected for processing (2)
  • pom.xml (3 hunks)
  • sofa-boot-tests/pom.xml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: sca
🔇 Additional comments (3)
pom.xml (2)

94-101: Double-check Central Publishing plugin coordinates & params

  1. Group Id org.sonatype.central and version 0.8.0 look plausible, but the official artefact is currently published under io.github.sonatype.central (verify against Maven Central).
  2. The plugin’s XML param was recently renamed from publishingServerIdserverId. Using the older key may cause “unknown parameter” failures.

Recommend confirming against the plugin’s latest README before releasing.


134-144: Validate new snapshot repository URL

https://central.sonatype.com/repository/maven-snapshots/ is still in beta and may intermittently redirect. Ensure:

  • Credentials on ${settings.xml} match <id>snapshot</id>
  • CI/CD firewalls allow the new host

A quick mvn -U deploy -DskipTests dry-run from CI will surface any connectivity issues early.

sofa-boot-tests/pom.xml (1)

70-76: Ensure parent defines central-publishing-maven-plugin.version

The version is inherited from the root POM. If anyone builds this module in isolation (e.g., via mvn -pl sofa-boot-tests -am install), the property must still resolve. Confirm the root POM is always included in such commands, or duplicate the property locally.

@CrazyHZM CrazyHZM deleted the 4.x_feat/nexus-staging-maven-plugin branch July 2, 2025 06:36
CrazyHZM added a commit that referenced this pull request Jul 2, 2025
CrazyHZM added a commit that referenced this pull request Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.91%. Comparing base (b316495) to head (fab8277).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1382      +/-   ##
============================================
- Coverage     82.96%   82.91%   -0.06%     
+ Complexity     2973     2972       -1     
============================================
  Files           340      340              
  Lines          9833     9833              
  Branches       1178     1178              
============================================
- Hits           8158     8153       -5     
- Misses         1160     1164       +4     
- Partials        515      516       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai bot mentioned this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant