Add warnings_are_errors and show_warnings to the cache info. #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Mar 12, 2025
| // Record the time that this version of lrpar was built. If the source code changes and | ||
| // rustc forces a recompile, this will change this value, causing anything which depends on | ||
| // this build of lrpar to be recompiled too. | ||
| let Self { |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
Should be fixed, by rustfmt but will need a squash. |
Member
|
Please squash. |
Rewrite the cache info variable accessors to be more fragile.
When done in the `let Self{ ... } = self;` style, this code
should now cause errors and lints as new fields get added.
ratmice
force-pushed
the
cache_error_flags
branch
from
1d5c9c4 to
005b54f
Compare
Collaborator
Author
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rewrite the cache info variable accessors to be more fragile. When done in the
let Self{ ... } = self;style, this code should now cause errors and lints as new fields get added.The comment I added mirrors the one in the struct decl but be more local to where the above fragility will happen.