Skip to content

Add warnings_are_errors and show_warnings to the cache info. #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ltratt merged 1 commit into from
Mar 12, 2025
Merged

Add warnings_are_errors and show_warnings to the cache info. #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions lrpar/src/lib/ctbuilder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,14 +811,27 @@ where
// Record the time that this version of lrpar was built. If the source code changes and
// rustc forces a recompile, this will change this value, causing anything which depends on
// this build of lrpar to be recompiled too.
let Self {
Copy link
Member

@ltratt ltratt Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very clever idiom!

// All variables except for `output_path` and `phantom` should
// be written into the cache.
grammar_path,
mod_name,
recoverer,
yacckind,
output_path: _,
error_on_conflicts,
warnings_are_errors,
show_warnings,
visibility,
rust_edition,
phantom: _,
} = self;
let build_time = env!("VERGEN_BUILD_TIMESTAMP");
let grammar_path = self.grammar_path.as_ref().unwrap().to_string_lossy();
let mod_name = QuoteOption(self.mod_name);
let recoverer = self.recoverer;
let yacckind = self.yacckind;
let visibility = self.visibility.to_variant_tokens();
let rust_edition = self.rust_edition.to_variant_tokens();
let error_on_conflicts = self.error_on_conflicts;
let grammar_path = grammar_path.as_ref().unwrap().to_string_lossy();
let mod_name = QuoteOption(mod_name.as_deref());
let visibility = visibility.to_variant_tokens();
let rust_edition = rust_edition.to_variant_tokens();
let yacckind = yacckind.expect("is_some() by this point");
let rule_map = grm
.iter_tidxs()
.map(|tidx| {
Expand All @@ -841,6 +854,8 @@ where
const RECOVERER: RecoveryKind = #recoverer;
const YACC_KIND: YaccKind = #yacckind;
const ERROR_ON_CONFLICTS: bool = #error_on_conflicts;
const SHOW_WARNINGS: bool = #show_warnings;
const WARNINGS_ARE_ERRORS: bool = #warnings_are_errors;
const RUST_EDITION: RustEdition = #rust_edition;
const RULE_IDS_MAP: [(usize, &str); #rule_map_len] = [#(#rule_map,)*];
fn visibility() -> Visibility {
Expand Down