Consistently underline error spans with '^' #579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes error messages consistently underline with the '^' character,
As discussed in #578, using different underline characters was intended for a more footnote style,
where we would avoid emitting duplicate source lines, by coalescing spans and use multiple underlines
on a single source line, then emitting error text as footnotes. But I never actually implemented that,
and it seems like it would probably be more difficult to read/follow.