Skip to content

Conversation

@ratmice
Copy link
Collaborator

@ratmice ratmice commented May 23, 2025

This makes error messages consistently underline with the '^' character,

As discussed in #578, using different underline characters was intended for a more footnote style,
where we would avoid emitting duplicate source lines, by coalescing spans and use multiple underlines
on a single source line, then emitting error text as footnotes. But I never actually implemented that,
and it seems like it would probably be more difficult to read/follow.

@ltratt
Copy link
Member

ltratt commented May 23, 2025

Thanks!

@ltratt ltratt added this pull request to the merge queue May 23, 2025
Merged via the queue into softdevteam:master with commit e5f7b80 May 23, 2025
2 checks passed
@ratmice ratmice deleted the consistent_underline branch May 23, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants