Skip to content

Consistently underline error spans with '^' #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ltratt merged 1 commit into from
May 23, 2025
Merged

Consistently underline error spans with '^' #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lrpar/src/lib/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ impl<'a> SpannedDiagnosticFormatter<'a> {
}
_ => "Unrecognized spanskind".to_string(),
};
out.push_str(&self.prefixed_underline_span_with_text(dots, *span, s, '-'));
out.push_str(&self.prefixed_underline_span_with_text(dots, *span, s, '^'));
}
}
out
Expand Down Expand Up @@ -293,9 +293,9 @@ impl<'a> SpannedDiagnosticFormatter<'a> {
),
);
out.pushln(self.underline_span_with_text(r1_span, "First reduce".to_string(), '^'));
out.pushln(self.underline_span_with_text(r2_span, "Second reduce".to_string(), '-'));
out.pushln(self.underline_span_with_text(r2_span, "Second reduce".to_string(), '^'));
if let Some(t_span) = t_span {
out.pushln(self.underline_span_with_text(t_span, "Lookahead".to_string(), '+'));
out.pushln(self.underline_span_with_text(t_span, "Lookahead".to_string(), '^'));
}
out.push('\n');
}
Expand All @@ -319,7 +319,7 @@ impl<'a> SpannedDiagnosticFormatter<'a> {
);

out.pushln(self.underline_span_with_text(s_tok_span, "Shift".to_string(), '^'));
out.pushln(self.underline_span_with_text(r_rule_span, "Reduced rule".to_string(), '+'));
out.pushln(self.underline_span_with_text(r_rule_span, "Reduced rule".to_string(), '^'));

if r_prod_spans.is_empty() {
r_prod_spans.push(fallback_span);
Expand Down