feat: audio param performance improvement #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poneciak57
changed the title
poneciak57
requested review from
maciejmakowski2003,
mdydek,
michalsek and
vltkv
msluszniak
reviewed
Sep 3, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/utils/ParamChangeEvent.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/AudioParam.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
maciejmakowski2003
requested changes
Sep 3, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/AudioParam.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/AudioParam.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/AudioParamEventQueue.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/AudioParam.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/AudioParam.cpp
Outdated
Show resolved
Hide resolved
vltkv
reviewed
Sep 3, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/AudioParamEventQueue.cpp
Outdated
Show resolved
Hide resolved
vltkv
reviewed
Sep 3, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/AudioParamEventQueue.cpp
Outdated
Show resolved
Hide resolved
vltkv
reviewed
Sep 4, 2025
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
mdydek
reviewed
Sep 4, 2025
mdydek
reviewed
Sep 4, 2025
packages/react-native-audio-api/common/cpp/audioapi/utils/RingBiDirectionalBuffer.hpp
Outdated
Show resolved
Hide resolved
vltkv
approved these changes
Sep 4, 2025
maciejmakowski2003
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-214
Significantly improved performance of audio param by enchancing the inter thread communication process while preserving the functionality.
Introduced changes
Checklist