Skip to content

feat: audio param performance improvement #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 4, 2025
Merged

feat: audio param performance improvement #639

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1ef8b89
feat: simple performant ring buff impl
poneciak57 Sep 2, 2025
fd9deb0
chore: ring buff neatpicks
poneciak57 Sep 2, 2025
b8b5eaf
feat: optimized param change event type
poneciak57 Sep 2, 2025
9782832
chore: minor changes
poneciak57 Sep 2, 2025
21d7295
feat: param events queue impl
poneciak57 Sep 2, 2025
1064773
feat: enchanced audio param impl
poneciak57 Sep 3, 2025
d1ea25f
chore: neatpicks
poneciak57 Sep 3, 2025
2492fae
chore: neatpicks
poneciak57 Sep 3, 2025
5f93c2a
chore: minor opts
poneciak57 Sep 3, 2025
ec97bdc
fix: fixed tests
poneciak57 Sep 3, 2025
96e7dd7
fix: comments
poneciak57 Sep 3, 2025
c22f022
fix: minor fixes
poneciak57 Sep 4, 2025
f21177a
fix: neatpicks
poneciak57 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/common-app/src/examples/DrumMachine/DrumMachine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ const DrumMachine: React.FC = () => {
label="BPM"
step={1}
min={24}
max={1000}
max={1500}
value={bpm}
onValueChange={setBpm}
/>
Expand Down
6 changes: 4 additions & 2 deletions packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioParamHostObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <audioapi/core/AudioParam.h>

#include <jsi/jsi.h>
#include <utility>
#include <memory>
#include <vector>
#include <cstddef>
Expand Down Expand Up @@ -81,12 +82,13 @@ class AudioParamHostObject : public JsiHostObject {

JSI_HOST_FUNCTION(setValueCurveAtTime) {
auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
auto values = reinterpret_cast<float *>(arrayBuffer.data(runtime));
auto rawValues = reinterpret_cast<float *>(arrayBuffer.data(runtime));
auto length = static_cast<int>(arrayBuffer.size(runtime));
auto values = std::make_unique<std::vector<float>>(rawValues, rawValues + length);

double startTime = args[1].getNumber();
double duration = args[2].getNumber();
param_->setValueCurveAtTime(values, length, startTime, duration);
param_->setValueCurveAtTime(std::move(values), length, startTime, duration);
return jsi::Value::undefined();
}

Expand Down
Loading