Skip to content

[iOS] Fix gestures not ending properly on iOS 26 #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+22 −9
Open

[iOS] Fix gestures not ending properly on iOS 26 #3740

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
046d216
Fix Pan
m-bert Oct 7, 2025
fc179b7
Fix Fling
m-bert Oct 7, 2025
2d5c200
Fix LongPress
m-bert Oct 7, 2025
8d30a08
Fix Tap
m-bert Oct 7, 2025
2573a30
Introduce iOS_VERSION macro
m-bert Oct 8, 2025
4213825
Remove triggerAction from reset
m-bert Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,21 @@ - (void)touchesEnded:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
_lastPoint = [[[touches allObjects] objectAtIndex:0] locationInView:_gestureHandler.recognizer.view];
[super touchesEnded:touches withEvent:event];
[_gestureHandler.pointerTracker touchesEnded:touches withEvent:event];

if (iOS_VERSION >= 26.0) {
[self triggerAction];
}
}

- (void)touchesCancelled:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
_lastPoint = [[[touches allObjects] objectAtIndex:0] locationInView:_gestureHandler.recognizer.view];
[super touchesCancelled:touches withEvent:event];
[_gestureHandler.pointerTracker touchesCancelled:touches withEvent:event];

if (iOS_VERSION >= 26.0) {
[self triggerAction];
}
}

- (void)triggerAction
Expand All @@ -69,7 +77,14 @@ - (void)triggerAction

- (void)reset
{
#if TARGET_OS_IOS
if (iOS_VERSION < 26.0) {
[self triggerAction];
}
#else
[self triggerAction];
#endif

[_gestureHandler.pointerTracker reset];
_hasBegan = NO;
[super reset];
Expand Down
14 changes: 13 additions & 1 deletion packages/react-native-gesture-handler/apple/Handlers/RNLongPressHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,20 @@ - (void)touchesEnded:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesEnded:touches withEvent:event];
[_gestureHandler.pointerTracker touchesEnded:touches withEvent:event];

if (iOS_VERSION >= 26.0 && self.state == UIGestureRecognizerStateFailed) {
[self triggerAction];
}
}

- (void)touchesCancelled:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesCancelled:touches withEvent:event];
[_gestureHandler.pointerTracker touchesCancelled:touches withEvent:event];

if (iOS_VERSION >= 26.0 && self.state == UIGestureRecognizerStateFailed) {
[self triggerAction];
}
}

#else
Expand Down Expand Up @@ -181,9 +189,13 @@ - (BOOL)shouldCancelGesture

- (void)reset
{
if (self.state == UIGestureRecognizerStateFailed) {
#if TARGET_OS_IOS
if (iOS_VERSION < 26.0 && self.state == UIGestureRecognizerStateFailed) {
[self triggerAction];
}
#else
[self triggerAction];
#endif

[_gestureHandler.pointerTracker reset];

Expand Down
15 changes: 15 additions & 0 deletions packages/react-native-gesture-handler/apple/Handlers/RNPanHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,19 +243,34 @@ - (void)touchesEnded:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesEnded:touches withEvent:event];
[self interactionsEnded:touches withEvent:event];

if (iOS_VERSION >= 26.0) {
[self triggerAction];
}
}

- (void)touchesCancelled:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesCancelled:touches withEvent:event];
[self interactionsCancelled:touches withEvent:event];

if (iOS_VERSION >= 26.0) {
[self triggerAction];
}
}

#endif

- (void)reset
{
#if TARGET_OS_IOS
if (iOS_VERSION < 26.0) {
[self triggerAction];
}
#else
[self triggerAction];
#endif

[_gestureHandler.pointerTracker reset];
[NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(activateAfterLongPress) object:nil];
self.enabled = YES;
Expand Down
15 changes: 14 additions & 1 deletion packages/react-native-gesture-handler/apple/Handlers/RNTapHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,20 @@ - (void)touchesEnded:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesEnded:touches withEvent:event];
[self interactionsEnded:touches withEvent:event];

if (iOS_VERSION >= 26.0 && self.state == UIGestureRecognizerStateFailed) {
[self triggerAction];
}
}

- (void)touchesCancelled:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesCancelled:touches withEvent:event];
[self interactionsCancelled:touches withEvent:event];

if (iOS_VERSION >= 26.0 && self.state == UIGestureRecognizerStateFailed) {
[self triggerAction];
}
}

#endif
Expand Down Expand Up @@ -243,9 +251,14 @@ - (BOOL)shouldFailUnderCustomCriteria

- (void)reset
{
if (self.state == UIGestureRecognizerStateFailed) {
#if TARGET_OS_IOS
if (iOS_VERSION < 26.0 && self.state == UIGestureRecognizerStateFailed) {
[self triggerAction];
}
#else
[self triggerAction];
#endif

[_gestureHandler.pointerTracker reset];

[NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(cancel) object:nil];
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-gesture-handler/apple/RNGHUIKit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ typedef UIScrollView RNGHUIScrollView;
#define RNGHGestureRecognizerStateBegan UIGestureRecognizerStateBegan;
#define RNGHGestureRecognizerStateEnded UIGestureRecognizerStateEnded;

#define iOS_VERSION [[[UIDevice currentDevice] systemVersion] floatValue]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, since iOS_VERSION macro returns float, we may want to do comparisons up to a constant $\epsilon$, or round this value. I don't think it is necessary at this point, but let me know what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont't really see a case where this would be an issue. I know floats behave weirdly, but we will always be checking it via a \leq or \geq comparison with another float and and the mapping from real values to floats is monotonic - it keeps the ordering.


#else // TARGET_OS_OSX [

#import <React/RCTUIKit.h>
Expand Down
Loading