Fix synchronous props updates on iOS below RN 0.81 #8427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejbloniarz
approved these changes
Oct 20, 2025
|
TODO: fix tvOS build edit: Fixed in 215738f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, animating props synchronously is broken on React Native 0.80 or older because
schedulerDidSynchronouslyUpdateViewOnUIThread:props:method that we're using was added facebook/react-native#51470 in which was released in React Native 0.81.In #8248, @patrycjakalinska added ifdefs to disable this flow on
react-native-macosbut it is not a problem with macOS itself but rather with the version of React Native (currently,macos-exampleruns on 0.79).This PR fixes animating props synchronously on iOS on React Native 0.80 and older.
Test plan