Add clang tidy performance checks

.clang-format

@@ -18,18 +18,6 @@ AlwaysBreakBeforeMultilineStrings: true
 AlwaysBreakTemplateDeclarations: true
 BinPackArguments: false
 BinPackParameters: false
-BraceWrapping:
-  AfterClass: false
-  AfterControlStatement: false
-  AfterEnum: false
-  AfterFunction: false
-  AfterNamespace: false
-  AfterObjCDeclaration: false
-  AfterStruct: false
-  AfterUnion: false
-  BeforeCatch: false
-  BeforeElse: false
-  IndentBraces: false
 BreakBeforeBinaryOperators: None
 BreakBeforeBraces: Attach
 BreakBeforeTernaryOperators: true

.clang-tidy

@@ -34,7 +34,7 @@ Checks:
   # - misc-*
   # - modernize-*
   # - objc-*
-  # - performance-*
+  - performance-*
   # - portability-*
   # - readability-*
 WarningsAsErrors: '*'

packages/react-native-reanimated/Common/cpp/reanimated/AnimatedSensor/AnimatedSensorModule.cpp

@@ -32,7 +32,7 @@ jsi::Value AnimatedSensorModule::registerSensor(
       "[Reanimated] Sensor event handler must be a worklet.");
 
   int sensorId = platformRegisterSensorFunction_(
-      sensorType,
+      static_cast<int>(sensorType),
       interval.asNumber(),
       iosReferenceFrame.asNumber(),
       [sensorType,

packages/react-native-reanimated/Common/cpp/reanimated/AnimatedSensor/AnimatedSensorModule.h

@@ -15,7 +15,7 @@ namespace reanimated {
 using namespace facebook;
 using namespace worklets;
 
-enum SensorType {
+enum class SensorType : std::uint8_t {
   ACCELEROMETER = 1,
   GYROSCOPE = 2,
   GRAVITY = 3,

packages/react-native-reanimated/Common/cpp/reanimated/CSS/common/transforms/TransformOp.h

@@ -4,7 +4,7 @@
 
 namespace reanimated::css {
 
-enum class TransformOp {
+enum class TransformOp : std::uint8_t {
   Perspective,
   Rotate,
   RotateX,

packages/react-native-reanimated/Common/cpp/reanimated/CSS/common/values/CSSColor.h

@@ -7,7 +7,7 @@
 
 namespace reanimated::css {
 
-enum class ColorType {
+enum class ColorType : std::uint8_t {
   Rgba,
   Transparent,
   CurrentColor, // for SVG

packages/react-native-reanimated/Common/cpp/reanimated/CSS/common/values/CSSValue.h

@@ -10,7 +10,7 @@ namespace reanimated::css {
 
 using namespace facebook;
 
-enum class RelativeTo {
+enum class RelativeTo : std::uint8_t {
   Parent,
   Self,
 };

packages/react-native-reanimated/Common/cpp/reanimated/CSS/configs/CSSAnimationConfig.cpp

@@ -124,7 +124,8 @@ template <typename TResult>
 std::unordered_map<size_t, TResult> parseHelper(
     jsi::Runtime &rt,
     const jsi::Object &settingsObj,
-    std::function<TResult(jsi::Runtime &, const jsi::Value &)> parseFunction) {
+    const std::function<TResult(jsi::Runtime &, const jsi::Value &)>
+        &parseFunction) {
   std::unordered_map<size_t, TResult> result;
 
   const auto animationIndices = settingsObj.getPropertyNames(rt);
@@ -173,14 +174,13 @@ CSSAnimationUpdates parseCSSAnimationUpdates(
   CSSAnimationUpdates result;
 
   if (configObj.hasProperty(rt, "animationNames")) {
-    const auto animationNames =
+    result.animationNames =
         parseAnimationNames(rt, configObj.getProperty(rt, "animationNames"));
-    result.animationNames = std::move(animationNames);
 
     if (configObj.hasProperty(rt, "newAnimationSettings")) {
       result.newAnimationSettings = parseNewAnimationSettings(
           rt,
-          animationNames,
+          result.animationNames.value(),
           configObj.getProperty(rt, "newAnimationSettings"));
     }
   }

packages/react-native-reanimated/Common/cpp/reanimated/CSS/configs/CSSAnimationConfig.h

@@ -11,9 +11,14 @@
 
 namespace reanimated::css {
 
-enum class AnimationDirection { Normal, Reverse, Alternate, AlternateReverse };
-enum class AnimationFillMode { None, Forwards, Backwards, Both };
-enum class AnimationPlayState { Running, Paused };
+enum class AnimationDirection : std::uint8_t {
+  Normal,
+  Reverse,
+  Alternate,
+  AlternateReverse
+};
+enum class AnimationFillMode : std::uint8_t { None, Forwards, Backwards, Both };
+enum class AnimationPlayState : std::uint8_t { Running, Paused };
 
 struct CSSAnimationSettings {
   double duration;

packages/react-native-reanimated/Common/cpp/reanimated/CSS/interpolation/transforms/operations/matrix.cpp

@@ -1,7 +1,6 @@
 #include <reanimated/CSS/interpolation/transforms/TransformOperationInterpolator.h>
 #include <reanimated/CSS/interpolation/transforms/operations/matrix.h>
 
-#include <algorithm>
 #include <deque>
 #include <memory>
 
@@ -143,7 +142,7 @@ MatrixOperation::MatrixOperation(TransformOperations operations)
     // Simplify operations to reduce the number of matrix
     // multiplications during matrix keyframe interpolation
     : TransformOperation(TransformOp::Matrix), value([&]() {
-        const auto &[value, is3D] = simplifyOperations(std::move(operations));
+        const auto &[value, is3D] = simplifyOperations(operations);
         is3D_ = is3D;
         return value;
       }()) {}

packages/react-native-reanimated/Common/cpp/reanimated/CSS/progress/AnimationProgressProvider.h

@@ -10,7 +10,7 @@
 
 namespace reanimated::css {
 
-enum class AnimationProgressState {
+enum class AnimationProgressState : std::uint8_t {
   Pending, // When the animation is waiting for the delay to pass
   Running,
   Paused,

packages/react-native-reanimated/Common/cpp/reanimated/CSS/progress/TransitionProgressProvider.h

@@ -12,7 +12,11 @@
 
 namespace reanimated::css {
 
-enum class TransitionProgressState { Pending, Running, Finished };
+enum class TransitionProgressState : std::uint8_t {
+  Pending,
+  Running,
+  Finished
+};
 
 class TransitionPropertyProgressProvider final
     : public KeyframeProgressProvider,

packages/react-native-reanimated/Common/cpp/reanimated/CSS/registries/CSSAnimationsRegistry.cpp

@@ -20,7 +20,7 @@ void CSSAnimationsRegistry::apply(
     const CSSAnimationsMap &newAnimations,
     const CSSAnimationSettingsUpdatesMap &settingsUpdates,
     double timestamp) {
-  const auto animationsVector =
+  auto animationsVector =
       buildAnimationsVector(rt, shadowNode, animationNames, newAnimations);
 
   const auto viewTag = shadowNode->getTag();
@@ -29,12 +29,6 @@ void CSSAnimationsRegistry::apply(
     return;
   }
 
-  registry_.erase(viewTag);
-  registry_.emplace(
-      viewTag,
-      RegistryEntry{
-          std::move(animationsVector),
-          buildAnimationToIndexMap(animationsVector)});
   runningAnimationIndicesMap_[viewTag].clear();
 
   std::vector<size_t> updatedIndices;
@@ -49,6 +43,14 @@ void CSSAnimationsRegistry::apply(
   for (size_t i = 0; i < animationsVector.size(); ++i) {
     scheduleOrActivateAnimation(i, animationsVector[i], timestamp);
   }
+
+  auto animationToIndexMap = buildAnimationToIndexMap(animationsVector);
+  registry_.erase(viewTag);
+  registry_.emplace(
+      viewTag,
+      RegistryEntry{
+          std::move(animationsVector), std::move(animationToIndexMap)});
+
   updateViewAnimations(viewTag, updatedIndices, timestamp, false);
   applyViewAnimationsStyle(viewTag, timestamp);
 }
@@ -93,7 +95,7 @@ CSSAnimationsVector CSSAnimationsRegistry::buildAnimationsVector(
   // the registry
   if (!animationNames.has_value()) {
     if (registryIt != registry_.end()) {
-      return std::move(registryIt->second.animationsVector);
+      return registryIt->second.animationsVector;
     }
   }
 

packages/react-native-reanimated/Common/cpp/reanimated/CSS/utils/DelayedItemsManager.cpp

@@ -3,8 +3,8 @@
 namespace reanimated::css {
 
 template <typename TValue>
-DelayedItem<TValue>::DelayedItem(const double timestamp, const TValue value)
-    : timestamp(timestamp), value(value) {}
+DelayedItem<TValue>::DelayedItem(double timestamp, TValue value)
+    : timestamp(timestamp), value(std::move(value)) {}
 
 template <typename TValue>
 bool DelayedItemComparator<TValue>::operator()(

packages/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/LayoutAnimationType.h

@@ -1,6 +1,8 @@
 #pragma once
 
-typedef enum LayoutAnimationType {
+#include <cstdint>
+
+typedef enum class LayoutAnimationType : std::uint8_t {
   ENTERING = 1,
   EXITING = 2,
   LAYOUT = 3,

packages/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/LayoutAnimationsManager.cpp

@@ -9,9 +9,9 @@ namespace reanimated {
 void LayoutAnimationsManager::configureAnimationBatch(
     const std::vector<LayoutAnimationConfig> &layoutAnimationsBatch) {
   auto lock = std::unique_lock<std::recursive_mutex>(animationsMutex_);
-  for (auto layoutAnimationConfig : layoutAnimationsBatch) {
+  for (const auto &layoutAnimationConfig : layoutAnimationsBatch) {
     const auto &[tag, type, config] = layoutAnimationConfig;
-    if (type == ENTERING) {
+    if (type == LayoutAnimationType::ENTERING) {
       enteringAnimationsForNativeID_[tag] = config;
       continue;
     }
@@ -110,11 +110,11 @@ void LayoutAnimationsManager::transferConfigFromNativeID(
 std::unordered_map<int, std::shared_ptr<Serializable>> &
 LayoutAnimationsManager::getConfigsForType(const LayoutAnimationType type) {
   switch (type) {
-    case ENTERING:
+    case LayoutAnimationType::ENTERING:
       return enteringAnimations_;
-    case EXITING:
+    case LayoutAnimationType::EXITING:
       return exitingAnimations_;
-    case LAYOUT:
+    case LayoutAnimationType::LAYOUT:
       return layoutAnimations_;
     default:
       throw std::invalid_argument("[Reanimated] Unknown layout animation type");