fix: free __cxa_demangle allocations in SingleInstanceChecker#8964
Open
jingjing2222 wants to merge 4 commits intosoftware-mansion:mainfrom
Open
fix: free __cxa_demangle allocations in SingleInstanceChecker#8964jingjing2222 wants to merge 4 commits intosoftware-mansion:mainfrom
jingjing2222 wants to merge 4 commits intosoftware-mansion:mainfrom
Conversation
jingjing2222
force-pushed
the
fix/single-instance-checker-demangle-leak
branch
from
1a92828 to
0f43296
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SingleInstanceCheckerby freeing__cxa_demangleresulttypeid(T).name()when demangling failsWhy
__cxa_demangleallocates memory that must be released withfree.The previous code copied into
std::stringbut never freed the original buffer.Scope
This fixes a deterministic native allocation leak in debug builds when these constructors run.