fix: multiple attributes in the transform not take effect #2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperzolkiewski
force-pushed
the
transformMultipleAttributes
branch
from
55375a3 to
8f4e16f
Compare
kacperzolkiewski
force-pushed
the
transformMultipleAttributes
branch
from
607a7c3 to
ed77bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes: #2686
This PR refactors how the transform prop is passed to native components.
Previously, the transform was converted into a transform matrix before being sent to native code. This caused issues when multiple transform attributes were applied, as they did not work correctly.
Changes
Pass the transform prop directly to native components instead of converting it to a transform matrix.
Removed the
transformsArrayToPropsfunction, which did not handle transforms correctly.Added a new
stringifyTransformArrayPropsfunction that converts a transform array into an SVG-compatible string (e.g. "rotate(45) translate(10)".Test Plan
Run the example from issue #2686 and verify if Rect displays correctly.
Run example apps and check if Transforms section displays correctly.
Compatibility
Checklist