Skip to content

fix: multiple attributes in the transform not take effect #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix: multiple attributes in the transform not take effect #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7f93d84
feat: provide transform prop directly to native components
kacperzolkiewski Aug 13, 2025
4457dac
feat: provide transform prop directly to native gradient components
kacperzolkiewski Aug 13, 2025
90da9e2
fix: adding transform array prop into transform matrix
kacperzolkiewski Aug 14, 2025
a103f6e
fix: remove unused matrix property
kacperzolkiewski Aug 14, 2025
56df490
fix: remove unused matrix property from codegen types
kacperzolkiewski Aug 14, 2025
6f3be36
fix: sync architectures
kacperzolkiewski Aug 14, 2025
e03a21d
fix: remove unused matrix property from native ios code
kacperzolkiewski Aug 14, 2025
dd82f1c
fix: transformToRn.pegjs matrix() function
kacperzolkiewski Aug 19, 2025
ed77bab
fix: revert gradient transform changes
kacperzolkiewski Aug 21, 2025
656e920
fix: revert pattern transform changes
kacperzolkiewski Aug 21, 2025
b22b6df
fix: remove unused setMatrix function
kacperzolkiewski Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ android/
apple/
windows/
src/lib/extract/transform.js
src/lib/extract/transformToRn.js
9 changes: 0 additions & 9 deletions android/src/main/java/com/horcrux/svg/RenderableViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,15 +389,6 @@ public void setDisplay(V node, String display) {
node.setDisplay(display);
}

@ReactProp(name = "matrix")
public void setMatrix(V node, Dynamic matrixArray) {
node.setMatrix(matrixArray);
}

public void setMatrix(V view, @Nullable ReadableArray value) {
view.setMatrix(value);
}

@Override
public void setTransform(VirtualView node, @Nullable ReadableArray matrix) {
setTransformProperty(node, matrix);
Expand Down
27 changes: 0 additions & 27 deletions android/src/main/java/com/horcrux/svg/VirtualView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,33 +310,6 @@ public void setOpacity(float opacity) {
invalidate();
}

public void setMatrix(Dynamic matrixArray) {
boolean isArrayType = !matrixArray.isNull() && matrixArray.getType().equals(ReadableType.Array);
setMatrix(isArrayType ? matrixArray.asArray() : null);
}

public void setMatrix(@Nullable ReadableArray matrixArray) {
if (matrixArray != null) {
int matrixSize = PropHelper.toMatrixData(matrixArray, sRawMatrix, mScale);
if (matrixSize == 6) {
if (mMatrix == null) {
mMatrix = new Matrix();
mInvMatrix = new Matrix();
}
mMatrix.setValues(sRawMatrix);
mInvertible = mMatrix.invert(mInvMatrix);
} else if (matrixSize != -1) {
FLog.w(ReactConstants.TAG, "RNSVG: Transform matrices must be of size 6");
}
} else {
mMatrix.reset();
mInvMatrix.reset();
mInvertible = true;
}
super.invalidate();
clearParentCache();
}

public void setResponsible(boolean responsible) {
mResponsible = responsible;
invalidate();
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGCircleManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGCircleManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGCircleManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGClipPathManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGClipPathManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGClipPathManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
4 changes: 0 additions & 4 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGDefsManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

import android.view.View;
import androidx.annotation.Nullable;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.uimanager.BaseViewManager;
import com.facebook.react.uimanager.BaseViewManagerDelegate;
import com.facebook.react.uimanager.LayoutShadowNode;
Expand All @@ -29,9 +28,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
2 changes: 0 additions & 2 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGDefsManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,10 @@

import android.view.View;
import androidx.annotation.Nullable;
import com.facebook.react.bridge.ReadableArray;

public interface RNSVGDefsManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGEllipseManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGEllipseManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGEllipseManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions ...oid/src/paper/java/com/facebook/react/viewmanagers/RNSVGForeignObjectManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion ...id/src/paper/java/com/facebook/react/viewmanagers/RNSVGForeignObjectManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGForeignObjectManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGGroupManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGGroupManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGGroupManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGImageManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGImageManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
public interface RNSVGImageManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGLineManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGLineManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGLineManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions ...id/src/paper/java/com/facebook/react/viewmanagers/RNSVGLinearGradientManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion ...d/src/paper/java/com/facebook/react/viewmanagers/RNSVGLinearGradientManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGLinearGradientManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGMarkerManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGMarkerManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGMarkerManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGMaskManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGMaskManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGMaskManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGPathManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGPathManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGPathManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGPatternManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGPatternManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGPatternManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions ...id/src/paper/java/com/facebook/react/viewmanagers/RNSVGRadialGradientManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion ...d/src/paper/java/com/facebook/react/viewmanagers/RNSVGRadialGradientManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGRadialGradientManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGRectManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGRectManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGRectManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGSymbolManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGSymbolManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGSymbolManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGTSpanManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGTSpanManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGTSpanManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
3 changes: 0 additions & 3 deletions android/src/paper/java/com/facebook/react/viewmanagers/RNSVGTextManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public void setProperty(T view, String propName, @Nullable Object value) {
case "opacity":
mViewManager.setOpacity(view, value == null ? 1f : ((Double) value).floatValue());
break;
case "matrix":
mViewManager.setMatrix(view, (ReadableArray) value);
break;
case "mask":
mViewManager.setMask(view, value == null ? null : (String) value);
break;
Expand Down
1 change: 0 additions & 1 deletion android/src/paper/java/com/facebook/react/viewmanagers/RNSVGTextManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
public interface RNSVGTextManagerInterface<T extends View> {
void setName(T view, @Nullable String value);
void setOpacity(T view, float value);
void setMatrix(T view, @Nullable ReadableArray value);
void setMask(T view, @Nullable String value);
void setMarkerStart(T view, @Nullable String value);
void setMarkerMid(T view, @Nullable String value);
Expand Down
Loading
Loading