Skip to content

SAM-EM Add-Ons support [v3.9.47] #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jul 29, 2025
Merged

Conversation

softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Jul 28, 2025

Description

  1. Implements SAM Economic Model AddOns support NREL/GEOPHIRES-X#408. (Currently using Add-ons with SAM-EM causes an exception.)
  2. Includes a fix to prevent result fields that can occur in multiple categories from being parsed into categories in which they are not present in a specific case report: Client result multicategory fields fix #92. This is relevant because SAM-EM includes Total Add-on CAPEX in Capital Costs, not Extended Economics, and I didn't want the web interface to show the Extended Economics result section since that's not how the case report is structured.

Documentation

Documentation added to SAM Economic Models page (fork link):

image image image

Testing & Verification

  1. New example: example_SAM-single-owner-PPA-3.txt
  2. Add-ons unit test
  3. Client result unit tests
  4. Web interface
    1. image
    2. image
    3. image
    4. image
    5. image
    6. image

TODO:

  1. Add example_SAM-single-owner-PPA-3 to web interface Examples table/selector
  2. AGS result parsing fix: e5e9bb2
  3. CHANGELOG entry: 555ebb8
  4. Naming consistency ("AddOn" vs. "Add-on")
  5. OutputParameter-ization: 1e6f1b4
  6. Unit tests
  7. Electricity: marked TODO faeae03
  8. Documentation
  9. Exclude EXTENDED ECONOMICS category from client result: da41556

@softwareengineerprogrammer softwareengineerprogrammer changed the title SAM-EM AddOns support SAM-EM Add-ons support Jul 28, 2025
@softwareengineerprogrammer softwareengineerprogrammer added the enhancement New feature or request label Jul 28, 2025
@softwareengineerprogrammer softwareengineerprogrammer changed the title SAM-EM Add-ons support SAM-EM Add-Ons support Jul 29, 2025
@softwareengineerprogrammer softwareengineerprogrammer added the bug Something isn't working label Jul 29, 2025
@softwareengineerprogrammer softwareengineerprogrammer changed the title SAM-EM Add-Ons support SAM-EM Add-Ons support [v3.9.45] Jul 29, 2025
@softwareengineerprogrammer softwareengineerprogrammer changed the title SAM-EM Add-Ons support [v3.9.45] SAM-EM Add-Ons support [v3.9.46] Jul 29, 2025
@softwareengineerprogrammer softwareengineerprogrammer changed the title SAM-EM Add-Ons support [v3.9.46] SAM-EM Add-Ons support [v3.9.47] Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant