pybind: Errors when compiling with clang#334
Merged
leonardocarreras merged 5 commits intosogno-platform:masterfrom May 19, 2025
Merged
pybind: Errors when compiling with clang#334leonardocarreras merged 5 commits intosogno-platform:masterfrom
leonardocarreras merged 5 commits intosogno-platform:masterfrom
Conversation
stv0g
previously approved these changes
Mar 25, 2025
Contributor
stv0g
left a comment
stv0g
left a comment
There was a problem hiding this comment.
Looks good to me :)
I dont see how this enables Clang compilation in the pipeline though.
But from my side, we can merge it
Contributor
Author
|
@stv0g I think there are probably more things to check and this is not fully finished, some structures are not accepted in the way they are by the compiler and produce errors on compilation or linking, I did not have the time to follow up |
leonardocarreras
force-pushed
the
fix-pybind-clang
branch
from
bc4b495 to
2ec22b3
Compare
Contributor
Author
|
With the changes (tested locally), after merging on villas and deploying the newer rocky container, we should be on a good path |
stv0g
reviewed
Apr 28, 2025
leonardocarreras
force-pushed
the
fix-pybind-clang
branch
from
8c3282f to
35c38a1
Compare
Contributor
Author
|
Almost ready, need to readapt the commit number. Waiting for VILLASframework/node#908 and VILLASframework/node#910 |
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
leonardocarreras
force-pushed
the
fix-pybind-clang
branch
from
35c38a1 to
9f6da1f
Compare
leonardocarreras
requested review from
dinkelbachjan,
m-mirz and
n-eiling
as code owners
Contributor
Author
|
This is stable enough for the moment, ready. |
georgii-tishenin
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix: