fix: project-10 test sol price feed id #39
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baiwfg2
reviewed
Sep 1, 2025
|
|
||
| const SOL_PRICE_FEED_ID = | ||
| '0xeaa020c61cc479712813461ce153894a96a6c00b21ed0cfc2798d1f9a9e9c94a'; | ||
| '0xef0d8b6fda2ceba41da15d4095d1da392a0d2f8ed0c6c7bc0f4cfac8c280b56d'; |
There was a problem hiding this comment.
This is wrong. If using this, Test borrow will report error Mismatched price feed id. Actually the value is correct, whereas the name is wrong. We should name it USDC_PRICE_FEED_ID = 0xeaa020c61cc479712813461ce153894a96a6c00b21ed0cfc2798d1f9a9e9c94a.
In Test borrow, priceUpdate: usdcUsdPriceFeedAccount should be passed.
baiwfg2
pushed a commit
to baiwfg2/developer-bootcamp-2024
that referenced
this pull request
Sep 1, 2025
When borrowing SOL, usdc priceFeedAccount needs to be passed, so that collateral value can be calculated for determining max amount of SOL to be borrowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect SOL/USD price feed ID