Skip to content

fix: project-10 test sol price feed id #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: project-10 test sol price feed id #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project-10-lending/tests/bankrun.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('Lending Smart Contract Tests', async () => {
});

const SOL_PRICE_FEED_ID =
'0xeaa020c61cc479712813461ce153894a96a6c00b21ed0cfc2798d1f9a9e9c94a';
'0xef0d8b6fda2ceba41da15d4095d1da392a0d2f8ed0c6c7bc0f4cfac8c280b56d';
Copy link

@baiwfg2 baiwfg2 Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. If using this, Test borrow will report error Mismatched price feed id. Actually the value is correct, whereas the name is wrong. We should name it USDC_PRICE_FEED_ID = 0xeaa020c61cc479712813461ce153894a96a6c00b21ed0cfc2798d1f9a9e9c94a.

In Test borrow, priceUpdate: usdcUsdPriceFeedAccount should be passed.


const solUsdPriceFeedAccount = pythSolanaReceiver
.getPriceFeedAccountAddress(0, SOL_PRICE_FEED_ID)
Expand Down