[js-client] Add tsc --noEmit to the js client test script and fix type error
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
fix-js-type
branch
from
9c338cb to
b685b87
Compare
grod220
previously approved these changes
Dec 9, 2025
samkim-crypto
force-pushed
the
fix-js-type
branch
from
b685b87 to
963478a
Compare
grod220
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is the same issue as solana-program/token-2022#885.
Summary of Changes
I added assertIsTransactionWithBlockhashLifetime in test/_setup.ts to explicitly narrow the transaction type to one using a blockhash.
I updated the test script in package.json to run tsc --noEmit before ava to ensure test files are type-checked during builds/tests.