Skip to content

feat(shapes): add sh:node constraints #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elf-pavlik merged 4 commits into from
Jul 26, 2025
Merged

feat(shapes): add sh:node constraints #61

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fccd1ef
feat(shapes): add sh:node constraints
elf-pavlik Jul 24, 2025
be702c2
chore(data): pass sh:node validation
elf-pavlik Jul 24, 2025
0e642c7
fix(shapes): add sh:class back but on node shapes
elf-pavlik Jul 25, 2025
1c3893c
fix(shapes): restore IRI for ex:provider
elf-pavlik Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions catalog-data.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ cdata:EDWADAproject a ex:Organization ;
cdata:EmberSolid a ex:Software ;
ex:landingPage <https://chuixuewan.github.io/solid-clinic/> ;
ex:name "Ember Solid" ;
ex:provider cdata:RedPencil ;
ex:provider cdata:Redpencil ;
ex:status con:Production ;
ex:subType con:SoftwareLibrary .

Expand Down Expand Up @@ -2096,7 +2096,7 @@ cdata:PASS a ex:Service ;
ex:repository <https://github.com/codeforpdx/PASS> ;
ex:serviceAudience "homeless people,housing services case workers"@en ;
ex:socialKeyword "access to public resources,housing"@en ;
ex:softwareStackIncludes cdata:CSS, cdata:PASSPlatform ;
ex:softwareStackIncludes cdata:CSS ;
ex:status con:Development ;
ex:subType con:SpecializedPodService .

Expand Down Expand Up @@ -3554,7 +3554,7 @@ cdata:StartinBloxCo a ex:Organization ;

cdata:StartinBloxDotCom a ex:Service ;
ex:name "Startin'Blox" ;
ex:provider cdata:StartinBlox ;
ex:provider cdata:StartinBloxCo ;
ex:serviceEndpoint <https://startinblox.com/> ;
ex:softwareStackIncludes cdata:CSS ;
ex:status con:Production ;
Expand Down
40 changes: 22 additions & 18 deletions catalog-shacl.shce
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ shape :CreativeWorkShape -> ex:CreativeWork ;
sh:name "landing page"@en ;
sh:description "URL(s) where the work is available, or described"
% .
ex:provider IRI %
Copy link
Member

@jeswr jeswr Jul 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional - it doesn't look like OrganizationShape requires focus nodes to be IRIs.

Same comment applies to other removals of IRI

Copy link
Member Author

@elf-pavlik elf-pavlik Jul 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that was by accident for ex:provider. I restored IRI in the last commit.
BTW I'm planning another commit which will add sh:node sh:IRI to all the shapes. In that case does it still make sense to keep those IRI on properties which value needs to conform to a specific shape or they are just redundant and better to be removed?

Copy link
Member

@jeswr jeswr Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They would be redundant. I suggest confirming this by running validation eith a test case you expect to fail.

ex:provider @:OrganizationShape %
sh:name "provider"@en ;
sh:description "Organization(s) responsible for creating the work"
% .
ex:author IRI ex:Person %
ex:author IRI @:PersonShape %
sh:name "author"@en
% .
ex:editor IRI ex:Person %
ex:editor IRI @:PersonShape %
sh:name "editor"@en
% .
ex:description xsd:string|rdf:langString [0..1] maxLength=2000 %
Expand All @@ -50,7 +50,7 @@ shape :EventShape -> ex:Event ;
ex:description xsd:string|rdf:langString [0..1] maxLength=2000 %
sh:name "description"@en
% .
ex:provider IRI %
ex:provider @:OrganizationShape %
sh:name "provider"@en ;
sh:description "organization(s) responsible for hosting the event"
% .
Expand Down Expand Up @@ -94,11 +94,11 @@ shape :ServiceShape -> ex:Service ;
sh:name "landing page"@en ;
sh:description "URL where the service is described"
% .
ex:softwareStackIncludes IRI %
ex:softwareStackIncludes @:SoftwareShape %
sh:name "software stack includes"@en ;
sh:description "software used by this service"
% .
ex:provider IRI %
ex:provider @:OrganizationShape %
sh:name "provider"@en ;
sh:description "Organization(s) responsible for providing the service"
% .
Expand All @@ -112,7 +112,8 @@ shape :ServiceShape -> ex:Service ;
% .
}
shape :SoftwareShape -> ex:Software ;
sh:name "Software"@en {
sh:name "Software"@en;
sh:class ex:Software {
ex:name xsd:string|rdf:langString [1..1] %
sh:name "name"@en
% .
Expand Down Expand Up @@ -148,15 +149,15 @@ shape :SoftwareShape -> ex:Software ;
sh:name "showcase" ;
sh:description "URL that can be opened in a web browser to use this app"
% .
ex:provider IRI %
ex:provider @:OrganizationShape %
sh:name "provider"@en ;
sh:description "organization(s) responsible for creating/maintaining the softare"
% .
ex:maintainer IRI ex:Person %
ex:maintainer IRI @:PersonShape %
sh:name "maintainer"@en ;
sh:description "person responsible for maintaining the software"
% .
ex:developer IRI ex:Person %
ex:developer IRI @:PersonShape %
sh:name "developer"@en ;
sh:description "person contributiong to the software"
% .
Expand All @@ -168,11 +169,11 @@ shape :SoftwareShape -> ex:Software ;
sh:name "technical keyword"@en ;
sh:description "comma-separated list for product type e.g. game, calendar, contacts manager"
% .
ex:conformsTo IRI ex:ClassOfProduct %
ex:conformsTo IRI @:ClassOfProductShape %
sh:name "conforms to"@en ;
sh:description "a class of product, from a specification, that this implementation conforms to"
% .
ex:hasDependencyOn IRI ex:Software %
ex:hasDependencyOn IRI @:SoftwareShape %
sh:name "has dependency on"@en ;
sh:description "a library/module that this software depends on"
% .
Expand All @@ -193,19 +194,20 @@ shape :SpecificationShape -> ex:Specification ;
sh:name "landing page"@en ;
sh:description "URL where the specification is described"
% .
ex:editor IRI ex:Person %
ex:editor IRI @:PersonShape %
sh:name "editor"@en
% .
ex:author IRI ex:Person %
ex:author IRI @:PersonShape %
sh:name "author"@en
% .
ex:definesConformanceFor IRI ex:ClassOfProduct %
ex:definesConformanceFor IRI @:ClassOfProductShape %
sh:name "defines conformance for"@en ;
sh:description "a class of product which this specification defines"
% .
}
shape :ClassOfProductShape -> ex:ClassOfProduct ;
sh:name "Class of Product"@en {
sh:name "Class of Product"@en;
sh:class ex:ClassOfProduct {
ex:name xsd:string|rdf:langString [1..1] %
sh:name "name"@en
% .
Expand Down Expand Up @@ -236,7 +238,8 @@ shape :OntologyShape -> ex:Ontology ;
% .
}
shape :OrganizationShape -> ex:Organization ;
sh:name "Organization"@en {
sh:name "Organization"@en;
sh:class ex:Organization {
ex:name xsd:string|rdf:langString [1..1] %
sh:name "name"@en
% .
Expand Down Expand Up @@ -274,7 +277,8 @@ shape :OrganizationShape -> ex:Organization ;
% .
}
shape :PersonShape -> ex:Person ;
sh:name "Person"@en {
sh:name "Person"@en;
sh:class ex:Person {
ex:name xsd:string|rdf:langString [1..1] %
sh:name "name"@en
% .
Expand Down