feat(shapes): add sh:node constraints#61
Conversation
jeff-zucker
left a comment
jeff-zucker
left a comment
There was a problem hiding this comment.
But cdata:PassPlatform is (the essential) part of the softwareStack. This is not the place to correct that error.
It's not in the data, when you add it you can add that relation back. |
| sh:name "landing page"@en ; | ||
| sh:description "URL(s) where the work is available, or described" | ||
| % . | ||
| ex:provider IRI % |
There was a problem hiding this comment.
Is this intentional - it doesn't look like OrganizationShape requires focus nodes to be IRIs.
Same comment applies to other removals of IRI
There was a problem hiding this comment.
Good catch, that was by accident for ex:provider. I restored IRI in the last commit.
BTW I'm planning another commit which will add sh:node sh:IRI to all the shapes. In that case does it still make sense to keep those IRI on properties which value needs to conform to a specific shape or they are just redundant and better to be removed?
There was a problem hiding this comment.
They would be redundant. I suggest confirming this by running validation eith a test case you expect to fail.
|
Everything should be ready ✅ |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
Data validation fails since this change surfaces few errors in dataI think corrections in data show how why adding
sh:nodeimproves validation.I hope it also will give me better typings in LDO 🤞