Skip to content

Rails 8: Include manifest.js in install generator#6122

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
mamhoff:create-manifest-js-in-generated-apps
Feb 14, 2025
Merged

Rails 8: Include manifest.js in install generator#6122
tvdeyen merged 1 commit intosolidusio:mainfrom
mamhoff:create-manifest-js-in-generated-apps

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Feb 13, 2025

We found we need to do this for dummy apps, but we also need to do it for generated apps.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff mamhoff requested a review from a team as a code owner February 13, 2025 16:42
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Feb 13, 2025
@mamhoff mamhoff force-pushed the create-manifest-js-in-generated-apps branch 2 times, most recently from 561e912 to 1ad0f3b Compare February 13, 2025 16:53
We found we need to do this for dummy apps, but we also need to do it
for generated apps.
@mamhoff mamhoff force-pushed the create-manifest-js-in-generated-apps branch from 1ad0f3b to 12a6033 Compare February 14, 2025 08:26
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.67%. Comparing base (37a5c8a) to head (12a6033).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ib/generators/solidus/install/install_generator.rb 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6122      +/-   ##
==========================================
- Coverage   88.68%   88.67%   -0.01%     
==========================================
  Files         830      830              
  Lines       18013    18015       +2     
==========================================
  Hits        15975    15975              
- Misses       2038     2040       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Martin!

@tvdeyen tvdeyen merged commit bec42f6 into solidusio:main Feb 14, 2025
19 of 21 checks passed
mamhoff added a commit to mamhoff/solidus that referenced this pull request Feb 14, 2025
…t-js-in-generated-apps"

This reverts commit bec42f6, reversing
changes made to 37a5c8a.
tvdeyen added a commit that referenced this pull request Feb 18, 2025
Revert "Merge pull request #6122 from mamhoff/create-manifest-js-in-g…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants