Rails 8: Include manifest.js in install generator#6122
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Feb 14, 2025
Merged
Rails 8: Include manifest.js in install generator#6122tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
561e912 to
1ad0f3b
Compare
tvdeyen
approved these changes
Feb 13, 2025
We found we need to do this for dummy apps, but we also need to do it for generated apps.
1ad0f3b to
12a6033
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6122 +/- ##
==========================================
- Coverage 88.68% 88.67% -0.01%
==========================================
Files 830 830
Lines 18013 18015 +2
==========================================
Hits 15975 15975
- Misses 2038 2040 +2 ☔ View full report in Codecov by Sentry. |
4 tasks
tvdeyen
added a commit
that referenced
this pull request
Feb 18, 2025
Revert "Merge pull request #6122 from mamhoff/create-manifest-js-in-g…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found we need to do this for dummy apps, but we also need to do it for generated apps.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: