Merged
Conversation
github-actions
bot
added
changelog:solidus_backend
mamhoff
force-pushed
the
use-firefox-for-system-specs
branch
2 times, most recently
from
78100e4 to
5155d17
Compare
github-actions
bot
added
changelog:solidus_admin
and removed
changelog:solidus_backend
mamhoff
force-pushed
the
use-firefox-for-system-specs
branch
3 times, most recently
from
a72bfa0 to
f9a17b3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6230 +/- ##
==========================================
+ Coverage 88.80% 88.87% +0.06%
==========================================
Files 842 842
Lines 18244 18230 -14
==========================================
Hits 16202 16202
+ Misses 2042 2028 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
force-pushed
the
use-firefox-for-system-specs
branch
from
f9a17b3 to
866af70
Compare
jarednorman
approved these changes
May 7, 2025
tvdeyen
requested changes
May 7, 2025
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
I am not opposed to using Firefox by default, but we should be transparent about it.
mamhoff
force-pushed
the
use-firefox-for-system-specs
branch
from
866af70 to
d0f8c07
Compare
tvdeyen
changed the title
capybara_driver.rb
Chrome seems to consistently get updated with new interesting options, and our specs have been sometimes more, and sometimes less flaky with Chrome as the browser that drives our system specs. This change uses the preconfigured `selenium_headless` driver from the Selenium gem, which uses Firefox under the hood. There are a few changes to helpers in the new admin. All of them have to with clicking table cells rather than the underlying table row. This is how real users also interact with the respective page, so I think it's a good change.
tvdeyen
force-pushed
the
use-firefox-for-system-specs
branch
from
d0f8c07 to
d5694a1
Compare
mamhoff
added a commit
to mamhoff/solidus_dev_support
that referenced
this pull request
May 15, 2025
Solidus core has migrated to using Firefox for headless testing, which seems to be more stable than Chrome, and uses minimal configuration. See solidusio/solidus#6230
4 tasks
tvdeyen
added
backport-v4.1
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
removed
backport-v4.1
Member
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mamhoff
added a commit
to mamhoff/solidus_dev_support
that referenced
this pull request
Aug 1, 2025
Solidus core has migrated to using Firefox for headless testing, which seems to be more stable than Chrome, and uses minimal configuration. See solidusio/solidus#6230 Because older versions of Solidus might not have the new `capybara_driver.rb` file, we still include the legacy code in a `rescue` block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chrome seems to consistently get updated with new interesting options,
and our specs have been sometimes more, and sometimes less flaky with
Chrome as the browser that drives our system specs.
This change uses the preconfigured
selenium_headlessdriver from theSelenium gem, which uses Firefox under the hood.
There are a few changes to helpers in the new admin. All of them have to
with clicking table cells rather than the underlying table row. This is
how real users also interact with the respective page, so I think it's a
good change.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: