Conversation
Chrome seems to consistently get updated with new interesting options, and our specs have been sometimes more, and sometimes less flaky with Chrome as the browser that drives our system specs. This change uses the preconfigured `selenium_headless` driver from the Selenium gem, which uses Firefox under the hood. There are a few changes to helpers in the new admin. All of them have to with clicking table cells rather than the underlying table row. This is how real users also interact with the respective page, so I think it's a good change. (cherry picked from commit d5694a1)
tvdeyen
added
backport-v4.5
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.5 #6263 +/- ##
==========================================
+ Coverage 88.72% 88.79% +0.06%
==========================================
Files 836 836
Lines 18175 18161 -14
==========================================
Hits 16126 16126
+ Misses 2049 2035 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.5:Questions ?
Please refer to the Backport tool documentation