Skip to content

Run tests on GitHub actions#6269

Merged
tvdeyen merged 4 commits intomainfrom
run-tests-on-github-actions
Jul 10, 2025
Merged

Run tests on GitHub actions#6269
tvdeyen merged 4 commits intomainfrom
run-tests-on-github-actions

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 31, 2025

Summary

Move our test runs from CircleCI to GitHub actions. This gives much faster feedback and keeps the tools
in one place.

Reviewer Note

The failing CircleCI check is expected since we removed the config in this PR, but the integration is still enabled.
The same is true for the required checks, that need to be updated after we merged this PR.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label May 31, 2025
@tvdeyen tvdeyen mentioned this pull request May 31, 2025
4 tasks
@tvdeyen tvdeyen force-pushed the run-tests-on-github-actions branch 16 times, most recently from 583ce2e to bc08acd Compare May 31, 2025 20:58
@tvdeyen tvdeyen moved this to In Progress in Solidus Public Roadmap May 31, 2025
@tvdeyen tvdeyen force-pushed the run-tests-on-github-actions branch from ae569c0 to 3118e1c Compare May 31, 2025 21:32
@tvdeyen tvdeyen force-pushed the run-tests-on-github-actions branch from 3118e1c to fd4a0f5 Compare June 18, 2025 15:10
@github-actions github-actions bot added changelog:repository Changes to the repository not within any gem and removed changelog:solidus_core Changes to the solidus_core gem labels Jun 18, 2025
@tvdeyen tvdeyen force-pushed the run-tests-on-github-actions branch 6 times, most recently from e43e78e to 9377494 Compare July 8, 2025 20:30
@tvdeyen tvdeyen added changelog:repository Changes to the repository not within any gem and removed changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Jul 10, 2025
@tvdeyen tvdeyen removed this from Solidus Admin Jul 10, 2025
@tvdeyen tvdeyen removed changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem labels Jul 10, 2025
@tvdeyen
Copy link
Member Author

tvdeyen commented Jul 10, 2025

Maybe we can also remove the bin/build-ci script now?

Removed

@tvdeyen tvdeyen requested a review from kennyadsl July 10, 2025 14:00
Otherwise we will get coverage mismatch warnings
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem and removed changelog:repository Changes to the repository not within any gem labels Jul 10, 2025
@tvdeyen tvdeyen added changelog:repository Changes to the repository not within any gem and removed changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem labels Jul 10, 2025
@tvdeyen tvdeyen removed this from Solidus Admin Jul 10, 2025
@tvdeyen tvdeyen merged commit 009ac6f into main Jul 10, 2025
47 of 48 checks passed
@tvdeyen tvdeyen deleted the run-tests-on-github-actions branch July 10, 2025 14:48
@github-project-automation github-project-automation bot moved this from In Progress to Done in Solidus Public Roadmap Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:repository Changes to the repository not within any gem

Projects

Development

Successfully merging this pull request may close these issues.

3 participants