Skip to content

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jun 4, 2025

Summary

This adds inverse_of and dependent options to has_many relation declarations in the promotions gem.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff mamhoff requested a review from a team as a code owner June 4, 2025 11:50
@github-actions github-actions bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label Jun 4, 2025
@mamhoff mamhoff force-pushed the promotions-has-many branch from b9e0c12 to 92aae5b Compare June 4, 2025 12:55
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (3333477) to head (a017a24).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6274      +/-   ##
==========================================
+ Coverage   86.63%   88.95%   +2.32%     
==========================================
  Files         520      860     +340     
  Lines       11946    18423    +6477     
==========================================
+ Hits        10349    16388    +6039     
- Misses       1597     2035     +438     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added this to the 4.6 milestone Jun 4, 2025
@mamhoff mamhoff force-pushed the promotions-has-many branch from 92aae5b to 4556905 Compare June 6, 2025 10:36
mamhoff added 2 commits June 18, 2025 13:29
All of these have foreign key constraints set and are actually necessary
for the respective records to function.
@mamhoff mamhoff force-pushed the promotions-has-many branch from 4556905 to a017a24 Compare June 18, 2025 11:29
@tvdeyen tvdeyen merged commit a2a55d6 into solidusio:main Jun 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_promotions Changes to the solidus_promotions gem

Projects

Development

Successfully merging this pull request may close these issues.

3 participants