Promotions: First Order condition must not fail on canceled orders #6343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6343 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 961 961
Lines 20165 20165
=======================================
Hits 18016 18016
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I warrant this back port worthy |
Member
|
@mamhoff you are too wasteful with your white space
|
spaghetticode
approved these changes
Oct 29, 2025
Member
spaghetticode
left a comment
spaghetticode
left a comment
There was a problem hiding this comment.
👍 and thanks for removing some nasty mocks 🙏
adammathys
approved these changes
Oct 29, 2025
The store I work in lets customers cancel their orders, and create a new one in its stead. The feature is described as "Edit your order" to customers. When they do this, the order they then place is perceived to be their first order, and I think we should respect that. Also changes the spec to work with actual records rather than mocking chains.
mamhoff
force-pushed
the
first-order-respect-canceled-orders
branch
from
69eb393 to
d259287
Compare
Member
|
Do you mind to also fix this in legacy_promotions? |
This rule also considered canceled first orders as first orders when it should not.
github-actions
bot
added
the
changelog:solidus_legacy_promotions
Contributor
Author
Done |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The store I work in lets customers cancel their orders, and create a new one in its stead. The feature is described as "Edit your order" to customers. When they do this, the order they then place is perceived to be their first order, and I think we should respect that.
Also changes the spec to work with actual records rather than mocking chains.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: