[v4.6] Promotions: First Order condition must not fail on canceled orders #6344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The store I work in lets customers cancel their orders, and create a new one in its stead. The feature is described as "Edit your order" to customers. When they do this, the order they then place is perceived to be their first order, and I think we should respect that. Also changes the spec to work with actual records rather than mocking chains. (cherry picked from commit d259287)
github-actions
bot
added
changelog:solidus_legacy_promotions
5 tasks
tvdeyen
approved these changes
Oct 31, 2025
Member
|
@solidusio/core-team we still have an issue with github token permissions for backport PRs. I will create a Solidus Bot token which have the permissions we need. The GitHub token does not have the permissions to trigger workflow runs for security reasons. |
This rule also considered canceled first orders as first orders when it should not. (cherry picked from commit 99f7562)
tvdeyen
force-pushed
the
backport/v4.6/pr-6343
branch
from
0aaeed1 to
2ea97d1
Compare
Member
|
Rebased with my commit it in order to trigger checks. This will hopefully finally be fixed by #6347 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.6 #6344 +/- ##
=======================================
Coverage 89.35% 89.35%
=======================================
Files 961 961
Lines 20195 20195
=======================================
Hits 18046 18046
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
All checks have passed - yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.6:Questions ?
Please refer to the Backport tool documentation