Skip to content

[v4.6] Promotions: First Order condition must not fail on canceled orders #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mamhoff merged 2 commits into from
Nov 1, 2025

Fix legacy promotions first order rule

2ea97d1
Select commit
Loading
Failed to load commit list.
Merged

[v4.6] Promotions: First Order condition must not fail on canceled orders #6344

Fix legacy promotions first order rule
2ea97d1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2025 in 0s

89.35% (+0.00%) compared to d724535

View this Pull Request on Codecov

89.35% (+0.00%) compared to d724535

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.35%. Comparing base (d724535) to head (2ea97d1).
⚠️ Report is 1 commits behind head on v4.6.

Additional details and impacted files 
@@           Coverage Diff           @@
##             v4.6    #6344   +/-   ##
=======================================
  Coverage   89.35%   89.35%           
=======================================
  Files         961      961           
  Lines       20195    20195           
=======================================
  Hits        18046    18046           
  Misses       2149     2149

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov