[v4.6] Promotions: Fix default calculator fields partial bug and make PercentWithCap calculator available in the UI #6394
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've added a promotion calculator, but we have not made it available to users. (cherry picked from commit 500f9a8)
mamhoff
added
backport-v4.6
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.6 #6394 +/- ##
=======================================
Coverage 89.36% 89.36%
=======================================
Files 963 963
Lines 20213 20213
=======================================
Hits 18064 18064
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@mamhoff test failures seem related? |
For all calculators except the `PercentWithCap` one we have a custom `calculator_fields` partial. PercentWithCap does not need that - it can fall back to the default calculator fields partial. However, that partial does not render currently, because `name` is a symbol that does not respond to `humanize`. Adds a system spec as well. (cherry picked from commit 7e1de2d)
mamhoff
force-pushed
the
backport/v4.6/pr-6381
branch
from
08481c7 to
3ef805b
Compare
Contributor
Author
|
Ha, and revealed another PR where the backports failed. #6233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.6:Questions ?
Please refer to the Backport tool documentation