Skip to content

Fix CS #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
szepeviktor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix CS #29

szepeviktor wants to merge 1 commit into from

Conversation

@szepeviktor
Copy link

@szepeviktor szepeviktor commented Jun 30, 2023 •
edited
Loading

@tweis Turns out ecs.php violated solutionDrive Coding Standard.

szepeviktor
szepeviktor commented Jun 30, 2023
View reviewed changes
.github/workflows/test-and-publish.yml
run: |
box compile
./build/ecs-standalone.phar check tests
./build/ecs-standalone.phar check -- ecs.php tests/
Copy link
Author

@szepeviktor szepeviktor Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always check ecs.php

szepeviktor
szepeviktor commented Jun 30, 2023
View reviewed changes
composer.json
"cweagans/composer-patches": "^1.7",
"slevomat/coding-standard": "^8.0",
"cweagans/composer-patches": "^1.7"
"symplify/easy-coding-standard": "^11.0"
Copy link
Author

@szepeviktor szepeviktor Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalize composer.json.
There is a Composer (JSON) schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@szepeviktor