Skip to content

Fix CS #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szepeviktor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix CS #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test-and-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,16 @@ jobs:
- name: script
run: |
composer validate --strict
vendor/bin/ecs check tests
vendor/bin/ecs check -- ecs.php tests/

- name: after success
run: |
cp ./ecs.php ./build/ecs${{ matrix.php-version }}.php

- name: before deploy
run: |
run: |
box compile
./build/ecs-standalone.phar check tests
./build/ecs-standalone.phar check -- ecs.php tests/
Copy link
Author

@szepeviktor szepeviktor Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always check ecs.php

mv ./build/ecs-standalone.phar ./build/coding-standard-standalone.ecs.php${{ matrix.php-version }}.phar

- name: deploy
Expand Down
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@
}
],
"require": {
"php": "^7.4||^8.0",
"symplify/easy-coding-standard": "^11.0",
"php": "^7.4 || ^8.0",
"cweagans/composer-patches": "^1.7",
"slevomat/coding-standard": "^8.0",
"cweagans/composer-patches": "^1.7"
"symplify/easy-coding-standard": "^11.0"
Copy link
Author

@szepeviktor szepeviktor Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalize composer.json.
There is a Composer (JSON) schema.

},
"config": {
"preferred-install": "source",
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true,
"cweagans/composer-patches": true
}
},
"preferred-install": "source"
},
"extra": {
"composer-exit-on-patch-failure": true,
Expand Down
6 changes: 6 additions & 0 deletions ecs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

declare(strict_types=1);

/*
* Created by netlogix GmbH & Co. KG
*
* @copyright netlogix GmbH & Co. KG
*/

use PhpCsFixer\Fixer\FunctionNotation\NativeFunctionInvocationFixer;
use Symplify\EasyCodingStandard\Config\ECSConfig;

Expand Down