Liquid Cooling leakage detection in SONiC #2032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuazhe
requested review from
Junchao-Mellanox,
eddyk-nvidia,
judyjoseph,
keboliu,
liat-grozovik,
prgeor and
rlhui
judyjoseph
reviewed
Jul 14, 2025
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
@judyjoseph , could you please help to review? |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
|
@judyjoseph Can you help review this HLD? Thanks |
judyjoseph
reviewed
Aug 15, 2025
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
Author
thanks, add more details on your comment |
11 tasks
Signed-off-by: Yuanzhe, Liu <[email protected]>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
|
@lguohan could you review too, anything which you would like w.r.to cooling leakage detection. Any other related working going on in cooling. thanks |
Junchao-Mellanox
approved these changes
Aug 25, 2025
11 tasks
This was referenced Sep 26, 2025
keboliu
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my HLD for the liquid cooling leakage detection, it provides a basic liquid cooling object to reflect the hardware as well as a mechanism to monitor the leakage sensors of it.
PR List: