add cli to show liquid cooling leakage status #4068
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@judyjoseph would you please help to review this PR? |
|
@yuazhe please add sample o/p fof the new CLI added in PR description |
thanks, I have updated it accordingly. |
scripts/leakageshow
Outdated
|
|
||
| from swsscommon.swsscommon import SonicV2Connector | ||
|
|
||
| header = ['Name', 'Leak'] |
There was a problem hiding this comment.
Can we change the header for the leak sensor status to Leaking from Leak?
show platform leakage status
Name Leaking
-----------------
leak_sensors1 NO
leak_sensors2 NO
...
leak_sensorsX Yes
I think this reads better. You would ask the question, "Is this sensor leaking?". Not, "Is this sensor leak?".
There was a problem hiding this comment.
Agree. @yuazhe please handle and sync team internally . then i can move on and merge it
There was a problem hiding this comment.
@nate-nexthop thanks for the correction, I have updated the PR
There was a problem hiding this comment.
Thanks! Please update the PR description with the new text
There was a problem hiding this comment.
done @liat-grozovik we should be good to move forward here.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yuanzhe, Liu <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7 participants
What I did
Following this HLD for liquid cooling sonic-net/SONiC#2032, I created this pr to add relevant CLI for checking liquid cooling status
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)