Skip to content

Conversation

@noaOrMlnx
Copy link
Collaborator

@noaOrMlnx noaOrMlnx commented Dec 15, 2024

Description

Add support for Virtium SSD which can't use SmartCMD - to use only smartctl (using generic ssd info parser).

Motivation and Context

There are Virtium SSDs which can't receive SSD info from 'SmartCMD', and must use 'smartctl' command.
For those SSDs, after calling the generic ssd parser, the function is finished and the specific vendor parser won't be called.

How Has This Been Tested?

I tested it manually with a special Virtium SSD which doesn't support SmartCMD

Additional Information (Optional)

output after the change:
root@sonic:/home/admin# show platform ssdhealth
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : 100.0%
Temperature : 52.0C

output before the change:
root@sonic:/home/admin# show platform ssdhealth
[Error] Cannot read SMART information on device /dev/nvme0n1
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : N/A
Temperature : 51.0C

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@noaOrMlnx
Copy link
Collaborator Author

/azpw run Azure.sonic-platform-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-platform-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@noaOrMlnx
Copy link
Collaborator Author

@wangxin A kind reminder, can you please handle the failure which is caused by moving from Bullseye to Bookworm?
Thanks

@noaOrMlnx
Copy link
Collaborator Author

/azpw run Azure.sonic-platform-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-platform-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

keboliu
keboliu previously approved these changes Dec 24, 2024
@noaOrMlnx
Copy link
Collaborator Author

@prgeor can you please take a look?

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@noaOrMlnx noaOrMlnx changed the title Add SpeicalVirtium vendor utility, for Virtium SSD which doesn't support SmartCMD Change Virtium SSD which doesn't support SmartCMD, to use only smartctl Jan 6, 2025
@noaOrMlnx noaOrMlnx requested review from ashwnsri and keboliu January 6, 2025 11:42
@noaOrMlnx noaOrMlnx force-pushed the special_virtium_ssd branch from 3604c4d to 4d16199 Compare January 6, 2025 12:15
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

keboliu
keboliu previously approved these changes Jan 7, 2025
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ashwnsri
Copy link
Contributor

ashwnsri commented Jan 8, 2025

@noaOrMlnx could you also fix output before/after change in the PR description to have uniform output format? One has disk type whereas other does not.

@noaOrMlnx
Copy link
Collaborator Author

@noaOrMlnx could you also fix output before/after change in the PR description to have uniform output format? One has disk type whereas other does not.

@assrinivasan Done

@noaOrMlnx
Copy link
Collaborator Author

@bingwang-ms can you please help to check that?

@noaOrMlnx
Copy link
Collaborator Author

@bingwang-ms @prgeor kind reminder. can you please help to merge?

@liat-grozovik liat-grozovik merged commit 75c320d into sonic-net:master Jan 16, 2025
5 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants