[action] [PR:522] Change Virtium SSD which doesn't support SmartCMD, to use only smartctl #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Provide a general summary of your changes in the Title above -->
#### Description
<!--
Describe your changes in detail
-->
Add support for Virtium SSD which can't use SmartCMD - to use only smartctl (using generic ssd info parser).
#### Motivation and Context
<!--
Why is this change required? What problem does it solve?
If this pull request closes/resolves an open Issue, make sure you
include the text "fixes #xxxx", "closes #xxxx" or "resolves #xxxx" here
-->
There are Virtium SSDs which can't receive SSD info from 'SmartCMD', and must use 'smartctl' command.
For those SSDs, after calling the generic ssd parser, the function is finished and the specific vendor parser won't be called.
#### How Has This Been Tested?
<!--
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
-->
I tested it manually with a special Virtium SSD which doesn't support SmartCMD
#### Additional Information (Optional)
output after the change:
root@sonic:/home/admin# show platform ssdhealth
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : 100.0%
Temperature : 52.0C
output before the change:
root@sonic:/home/admin# show platform ssdhealth
[Error] Cannot read SMART information on device /dev/nvme0n1
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : N/A
Temperature : 51.0C
Collaborator
Author
|
Original PR: #522 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Virtium SSD which can't use SmartCMD - to use only smartctl (using generic ssd info parser).
Motivation and Context
There are Virtium SSDs which can't receive SSD info from 'SmartCMD', and must use 'smartctl' command.
For those SSDs, after calling the generic ssd parser, the function is finished and the specific vendor parser won't be called.
How Has This Been Tested?
I tested it manually with a special Virtium SSD which doesn't support SmartCMD
Additional Information (Optional)
output after the change:
root@sonic:/home/admin# show platform ssdhealth
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : 100.0%
Temperature : 52.0C
output before the change:
root@sonic:/home/admin# show platform ssdhealth
[Error] Cannot read SMART information on device /dev/nvme0n1
Disk Type : NVME
Device Model : Virtium VTPM24CEXI080-BM110006
Health : N/A
Temperature : 51.0C