-
Notifications
You must be signed in to change notification settings - Fork 124
dot3 SNMP counters as per RFC3635 #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bhouse-nexthop
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
bhouse-nexthop:bhouse-nexthop/dot3stats
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
dot3 SNMP counters as per RFC3635 #350
bhouse-nexthop
wants to merge
1
commit into
sonic-net:master
from
bhouse-nexthop:bhouse-nexthop/dot3stats
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
Output from Mellanox SN2201: |
dot3 statistics are used for monitoring and debugging and are common among switch vendors to have implemented. This commit implements the dot3StatsTable and dot3HCStatsTable. Based on the code in rfc1213.py and rfc2863.py. Signed-off-by: Brad House <[email protected]>
ff57c19 to
fc897a7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Nov 17, 2025
* dot3 Stats collection What I did Implement RFC3635 dot3 statistics collection. Used by sonic-net/sonic-snmpagent#350 Fixes sonic-net/sonic-buildimage#22359 Why I did it RFC1284 defines dot3 stats that most switch vendors support. This RFC was superseded by RFC3635 which includes 64bit "HC" counters. We need to collect these statistics for use by sonic_snmpagent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Implement RFC3635 dot3 statistics reporting.
Depends on sonic-net/sonic-swss#3615
Fixes sonic-net/sonic-buildimage#22359
- How I did it
dot3 statistics are used for monitoring and debugging and are common among switch vendors to have implemented. This commit implements the dot3StatsTable and dot3HCStatsTable. A majority of this code comes directly from the pre-existing rfc2863.py, combined with a couple of snippets from rfc1213.py. The only original code is the actual mappings between the SAI variables and MIB OIDs.
- How to verify it
Tested on Mellanox SN2201 hardware, where the SAI implements dot3 stats. Broadcom SAI does not currently implement this.
- Description for the changelog
dot3 SNMP counters as per RFC3635 (originally RFC1284)